Skip to content

[Merged by Bors] - chore(Order/BooleanAlgebra): golf entire diff_insert_of_notMem, insert_diff_of_mem, insert_diff_of_notMem and subset_insert_iff using grind#28628

Closed
euprunin wants to merge 1 commit intoleanprover-community:masterfrom
euprunin:golf-cclxxvi
Closed

Conversation

@euprunin
Copy link
Copy Markdown
Contributor


Open in Gitpod

@github-actions github-actions Bot added the t-order Order theory label Aug 19, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 19, 2025

PR summary 59c724d051

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Aug 27, 2025

Can you say something about the performance of this change - and bundle with other Order PR, please? Thanks!

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 27, 2025
…sert_diff_of_mem`, `insert_diff_of_notMem` and `subset_insert_iff` using `grind`
@ghost
Copy link
Copy Markdown

ghost commented Sep 4, 2025

!bench

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit fdc159a.
There were no significant changes against commit 59c724d.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 4, 2025

File Instructions %
build -4.906⬝10⁹ (+0.00%)
2 files, Instructions -2.0⬝10⁹
File Instructions %
Mathlib.Data.List.Map2 -1.26⬝10⁹ (-12.84%)
Mathlib.Algebra.Homology.HomotopyCategory.Pretriangulated -1.201⬝10⁹ (-0.88%)

CI run Lakeprof report

@euprunin
Copy link
Copy Markdown
Contributor Author

euprunin commented Sep 5, 2025

@grunweg Thanks for reviewing! Based on the !bench results this change seems to be performance neutral.

@euprunin euprunin removed the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 5, 2025
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 8, 2025

🚀 Pull request has been placed on the maintainer queue by grunweg.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 8, 2025
@bryangingechen
Copy link
Copy Markdown
Contributor

Thanks!
bors r+

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Sep 8, 2025
mathlib-bors Bot pushed a commit that referenced this pull request Sep 8, 2025
…sert_diff_of_mem`, `insert_diff_of_notMem` and `subset_insert_iff` using `grind` (#28628)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Sep 8, 2025

Build failed (retrying...):

mathlib-bors Bot pushed a commit that referenced this pull request Sep 8, 2025
…sert_diff_of_mem`, `insert_diff_of_notMem` and `subset_insert_iff` using `grind` (#28628)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Sep 8, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(Order/BooleanAlgebra): golf entire diff_insert_of_notMem, insert_diff_of_mem, insert_diff_of_notMem and subset_insert_iff using grind [Merged by Bors] - chore(Order/BooleanAlgebra): golf entire diff_insert_of_notMem, insert_diff_of_mem, insert_diff_of_notMem and subset_insert_iff using grind Sep 8, 2025
@mathlib-bors mathlib-bors Bot closed this Sep 8, 2025
yuanyi-350 pushed a commit to yuanyi-350/yuanyi_mathlib4 that referenced this pull request Sep 10, 2025
…sert_diff_of_mem`, `insert_diff_of_notMem` and `subset_insert_iff` using `grind` (leanprover-community#28628)
robertmaxton42 pushed a commit to robertmaxton42/mathlib4 that referenced this pull request Sep 11, 2025
…sert_diff_of_mem`, `insert_diff_of_notMem` and `subset_insert_iff` using `grind` (leanprover-community#28628)
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
…sert_diff_of_mem`, `insert_diff_of_notMem` and `subset_insert_iff` using `grind` (leanprover-community#28628)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants