Skip to content

[Merged by Bors] - refactor(Algebra/Order/Module): don't use elim as a field name#29340

Closed
YaelDillies wants to merge 1 commit intoleanprover-community:masterfrom
YaelDillies:pos_smul_no_elim
Closed

[Merged by Bors] - refactor(Algebra/Order/Module): don't use elim as a field name#29340
YaelDillies wants to merge 1 commit intoleanprover-community:masterfrom
YaelDillies:pos_smul_no_elim

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies commented Sep 4, 2025

This prevented us from defining further typeclasses by extending.

Also move earlier an instance that somehow got stranded in Data.Finsupp.Weight.


Open in Gitpod

This prevented us from defining further typeclasses by extending.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 4, 2025

PR summary 419963adcc

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance {G : Type*} [PartialOrder G] [AddCommGroup G] [IsOrderedAddMonoid G] :
+ instance {M : Type*} [PartialOrder M] [AddCommMonoid M] [IsOrderedAddMonoid M] :
+ instance {M : Type*} [PartialOrder M] [AddCommMonoid M] [IsOrderedCancelAddMonoid M] :
- instance : SMulPosMono ℕ M

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@dupuisf
Copy link
Copy Markdown
Contributor

dupuisf commented Sep 4, 2025

Looks good!

bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Sep 4, 2025
mathlib-bors Bot pushed a commit that referenced this pull request Sep 4, 2025
)

This prevented us from defining further typeclasses by extending.

Also move earlier an instance that somehow got stranded in `Data.Finsupp.Weight`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Sep 4, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title refactor(Algebra/Order/Module): don't use elim as a field name [Merged by Bors] - refactor(Algebra/Order/Module): don't use elim as a field name Sep 4, 2025
@mathlib-bors mathlib-bors Bot closed this Sep 4, 2025
@YaelDillies YaelDillies deleted the pos_smul_no_elim branch September 4, 2025 19:32
CBirkbeck pushed a commit to CBirkbeck/mathlib4 that referenced this pull request Sep 8, 2025
…nprover-community#29340)

This prevented us from defining further typeclasses by extending.

Also move earlier an instance that somehow got stranded in `Data.Finsupp.Weight`.
yuanyi-350 pushed a commit to yuanyi-350/yuanyi_mathlib4 that referenced this pull request Sep 10, 2025
…nprover-community#29340)

This prevented us from defining further typeclasses by extending.

Also move earlier an instance that somehow got stranded in `Data.Finsupp.Weight`.
robertmaxton42 pushed a commit to robertmaxton42/mathlib4 that referenced this pull request Sep 11, 2025
…nprover-community#29340)

This prevented us from defining further typeclasses by extending.

Also move earlier an instance that somehow got stranded in `Data.Finsupp.Weight`.
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
…nprover-community#29340)

This prevented us from defining further typeclasses by extending.

Also move earlier an instance that somehow got stranded in `Data.Finsupp.Weight`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants