Skip to content

Fix simp tagging#29368

Closed
loefflerd wants to merge 40 commits intoleanprover-community:masterfrom
loefflerd:DL_fix_simps_for_CB
Closed

Fix simp tagging#29368
loefflerd wants to merge 40 commits intoleanprover-community:masterfrom
loefflerd:DL_fix_simps_for_CB

Conversation

@loefflerd
Copy link
Copy Markdown
Contributor

Fix a mess I created with #28690


Open in Gitpod

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Sep 5, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 5, 2025

PR summary ee1b32ba2b

Import changes exceeding 2%

% File
+119.50% Mathlib.NumberTheory.TsumDivsorsAntidiagonal

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.NumberTheory.TsumDivsorsAntidiagonal 723 1587 +864 (+119.50%)
Import changes for all files
Files Import difference
Mathlib.NumberTheory.TsumDivsorsAntidiagonal 864

Declarations diff

+ norm_natCast
+ sigma_eq_sum_div
+ summable_divisorsAntidiagonal_aux
+ summable_mul_tendsto_const
+ summable_norm_pow_mul_geometric_div_one_sub
+ summable_prod_mul_pow
+ tprod_congr₂
+ tsum_pow_div_one_sub_eq_tsum_sigma
+ tsum_prod_pow_eq_tsum_sigma

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@loefflerd loefflerd changed the title Dl fix simps for cb Fix simp tagging Sep 5, 2025
@loefflerd loefflerd added the WIP Work in progress label Sep 5, 2025
@loefflerd loefflerd closed this Sep 5, 2025
@loefflerd loefflerd deleted the DL_fix_simps_for_CB branch September 8, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants