Skip to content

[Merged by Bors] - chore: reduce open Fin.NatCast#29443

Closed
Komyyy wants to merge 1 commit intoleanprover-community:masterfrom
Komyyy:Fin.NatCast2
Closed

[Merged by Bors] - chore: reduce open Fin.NatCast#29443
Komyyy wants to merge 1 commit intoleanprover-community:masterfrom
Komyyy:Fin.NatCast2

Conversation

@Komyyy
Copy link
Copy Markdown
Contributor

@Komyyy Komyyy commented Sep 8, 2025


Open in Gitpod

@Komyyy Komyyy added t-algebra Algebra (groups, rings, fields, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Sep 8, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 8, 2025

PR summary 0ad288bf4a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.07)
Current number Change Type
14 -1 NatCast (Fin n) instances

Current commit 90e08565a4
Reference commit 0ad288bf4a

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@eric-wieser
Copy link
Copy Markdown
Member

bors d+

Thanks!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Sep 8, 2025

✌️ Komyyy can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Sep 8, 2025
@Komyyy
Copy link
Copy Markdown
Contributor Author

Komyyy commented Sep 8, 2025

bors r+

mathlib-bors Bot pushed a commit that referenced this pull request Sep 8, 2025
Co-authored-by: Komyyy <pol_tta@outlook.jp>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Sep 8, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore: reduce open Fin.NatCast [Merged by Bors] - chore: reduce open Fin.NatCast Sep 8, 2025
@mathlib-bors mathlib-bors Bot closed this Sep 8, 2025
@Komyyy Komyyy deleted the Fin.NatCast2 branch September 8, 2025 18:26
yuanyi-350 pushed a commit to yuanyi-350/yuanyi_mathlib4 that referenced this pull request Sep 10, 2025
Co-authored-by: Komyyy <pol_tta@outlook.jp>
robertmaxton42 pushed a commit to robertmaxton42/mathlib4 that referenced this pull request Sep 11, 2025
Co-authored-by: Komyyy <pol_tta@outlook.jp>
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
Co-authored-by: Komyyy <pol_tta@outlook.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants