Skip to content

[Merged by Bors] - feat: add group/field versions of Filter.map_*_atTop_eq_nat#29532

Closed
Aaron1011 wants to merge 2 commits intoleanprover-community:masterfrom
Aaron1011:big-o-attop
Closed

[Merged by Bors] - feat: add group/field versions of Filter.map_*_atTop_eq_nat#29532
Aaron1011 wants to merge 2 commits intoleanprover-community:masterfrom
Aaron1011:big-o-attop

Conversation

@Aaron1011
Copy link
Copy Markdown
Collaborator

@Aaron1011 Aaron1011 commented Sep 11, 2025

Add Filter.map_add_atTop_eq, Filter.map_sub_atTop_eq, and Filter.map_div_atTop_eq, which correspond to
Filter.map_add_atTop_eq_nat, Filter.map_sub_atTop_eq_nat, and Filter.map_div_atTop_eq_nat respectively.
These theorems apply to ordered groups/fields

Open in Gitpod

@Aaron1011
feat: add group/field versions of Filter.map_*_atTop_eq_nat
1e50ff7 
Add Filter.map_add_atTop_eq, Filter.map_sub_atTop_eq, and
Filter.map_div_atTop_eq, which correspond to
Filter.map_add_atTop_eq_nat, Filter.map_sub_atTop_eq_nat,
and Filter.map_div_atTop_eq_nat respectively.
These theorems apply to ordered groups/fields
@github-actions github-actions bot added new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-order Order theory large-import Automatically added label for PRs with a significant increase in transitive imports labels Sep 11, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 11, 2025 •
edited
Loading

PR summary 5197d2766d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ map_add_atTop_eq
+ map_div_atTop_eq
+ map_sub_atTop_eq

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Sep 11, 2025
Ruben-VandeVelde
Ruben-VandeVelde approved these changes Sep 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 17, 2025

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 17, 2025
bryangingechen
bryangingechen approved these changes Sep 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Sep 19, 2025
mathlib-bors bot pushed a commit that referenced this pull request Sep 19, 2025
@Aaron1011
feat: add group/field versions of Filter.map_*_atTop_eq_nat (#29532)
e900d23 
Add Filter.map_add_atTop_eq, Filter.map_sub_atTop_eq, and Filter.map_div_atTop_eq, which correspond to
Filter.map_add_atTop_eq_nat, Filter.map_sub_atTop_eq_nat, and Filter.map_div_atTop_eq_nat respectively.
These theorems apply to ordered groups/fields
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 19, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add group/field versions of Filter.map_*_atTop_eq_nat [Merged by Bors] - feat: add group/field versions of Filter.map_*_atTop_eq_nat Sep 19, 2025
@mathlib-bors mathlib-bors bot closed this Sep 19, 2025
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
@Aaron1011 @joelriou
feat: add group/field versions of Filter.map_*_atTop_eq_nat (leanprov…
6f2d582 
…er-community#29532)

Add Filter.map_add_atTop_eq, Filter.map_sub_atTop_eq, and Filter.map_div_atTop_eq, which correspond to
Filter.map_add_atTop_eq_nat, Filter.map_sub_atTop_eq_nat, and Filter.map_div_atTop_eq_nat respectively.
These theorems apply to ordered groups/fields
zhuyizheng pushed a commit to zhuyizheng/mathlib4 that referenced this pull request Oct 2, 2025
@Aaron1011 @zhuyizheng
feat: add group/field versions of Filter.map_*_atTop_eq_nat (leanprov…
9c2703f 
…er-community#29532)

Add Filter.map_add_atTop_eq, Filter.map_sub_atTop_eq, and Filter.map_div_atTop_eq, which correspond to
Filter.map_add_atTop_eq_nat, Filter.map_sub_atTop_eq_nat, and Filter.map_div_atTop_eq_nat respectively.
These theorems apply to ordered groups/fields
@dwrensha dwrensha mentioned this pull request Nov 4, 2025
Merged
thefundamentaltheor3m pushed a commit to thefundamentaltheor3m/Sphere-Packing-Lean that referenced this pull request Nov 10, 2025
@dwrensha @pitmonticone
chore: bump to v4.24.0 (#172)
f28f5ec 
* The definition of `ModularForm` was generalized:
leanprover-community/mathlib4#26651
* `Summable` has a `SummationFilter` parameter now:
leanprover-community/mathlib4#29914
* `f` parameter of `tprod_pnat_eq_tprod_succ` is now implicit:
leanprover-community/mathlib4#27841
* various lemmas were deprecated
* A lemma named `Filter.map_add_atTop_eq` was added to mathlib:
leanprover-community/mathlib4#29532
* other changes too...

---------

Co-authored-by: Pietro Monticone <38562595+pitmonticone@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees

No one assigned

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-order Order theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Aaron1011 @bryangingechen @Ruben-VandeVelde
⚡