[Merged by Bors] - chore(Finsupp): move mapRange.equiv earlier#31324
Closed
YaelDillies wants to merge 3 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore(Finsupp): move mapRange.equiv earlier#31324YaelDillies wants to merge 3 commits intoleanprover-community:masterfrom
mapRange.equiv earlier#31324YaelDillies wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
Move `mapRange.equiv` to `Data.Finsupp.Defs` and `mapRange.addEquiv` to `Algebra.Group.Finsupp`. This lets us not import fields when defining `finsuppAntidiag`. As previously, I am basing myself off the idea that `Finsupp` will at some point in the future be generalised to other base points (rather than just `0` as it is now), and that therefore anything under `Data.Finsupp` should not be algebraic (apart from mentioning `0`).
1 task
PR summary 85b1253058
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Order.Antidiag.Finsupp | 790 | 748 | -42 (-5.32%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Algebra.Order.Antidiag.Finsupp |
-42 |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
wwylele
approved these changes
Nov 6, 2025
Contributor
|
bors merge |
ghost
added
the
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 14, 2025
Move `mapRange.equiv` to `Data.Finsupp.Defs` and `mapRange.addEquiv` to `Algebra.Group.Finsupp`. This lets us not import fields when defining `finsuppAntidiag`. As previously, I am basing myself off the idea that `Finsupp` will at some point in the future be generalised to other base points (rather than just `0` as it is now), and that therefore anything under `Data.Finsupp` should not be algebraic (apart from mentioning `0`).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
mapRange.equiv earliermapRange.equiv earlier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
mapRange.equivtoData.Finsupp.DefsandmapRange.addEquivtoAlgebra.Group.Finsupp. This lets us not import fields when definingfinsuppAntidiag.As previously, I am basing myself off the idea that
Finsuppwill at some point in the future be generalised to other base points (rather than just0as it is now), and that therefore anything underData.Finsuppshould not be algebraic (apart from mentioning0).