Skip to content

[Merged by Bors] - feat(Topology/Sets): injectivity of Compacts.map#31381

Closed
gasparattila wants to merge 3 commits intoleanprover-community:masterfrom
gasparattila:compacts-map-injective
Closed

[Merged by Bors] - feat(Topology/Sets): injectivity of Compacts.map#31381
gasparattila wants to merge 3 commits intoleanprover-community:masterfrom
gasparattila:compacts-map-injective

Conversation

@gasparattila
Copy link
Copy Markdown
Contributor

@gasparattila gasparattila commented Nov 8, 2025

@gasparattila
Copy link
Copy Markdown
Contributor Author

easy

@github-actions github-actions bot added the easy < 20s of review time. See the lifecycle page for guidelines. label Nov 8, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2025

PR summary af43db4df4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ map_injective
+ map_injective_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Nov 8, 2025
@plp127
Copy link
Copy Markdown
Contributor

plp127 commented Nov 8, 2025

Can you add an iff version?

@plp127 plp127 added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 8, 2025
@gasparattila
Copy link
Copy Markdown
Contributor Author

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 8, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 8, 2025
@gasparattila gasparattila force-pushed the compacts-map-injective branch from d4be0aa to 793dbd0 Compare November 12, 2025 14:00
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 12, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

This PR/issue depends on:

@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Nov 12, 2025

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 12, 2025

✌️ gasparattila can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 12, 2025
@gasparattila
Copy link
Copy Markdown
Contributor Author

bors r+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 12, 2025

Build failed:

@gasparattila
Copy link
Copy Markdown
Contributor Author

bors r+

@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Nov 12, 2025

bors r-

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 12, 2025

Canceled.

@ghost ghost removed the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 12, 2025
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Nov 12, 2025

@gasparattila I cancelled this because it looks like you may have overlooked my suggestion to add simp to map_injective_iff.

Could you try that please before sending this back to bors?

@gasparattila
Copy link
Copy Markdown
Contributor Author

Sorry, for some reason your message suggesting the simp didn't appear for me and I still can't see it. I've added it now.

bors r+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 12, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/Sets): injectivity of Compacts.map [Merged by Bors] - feat(Topology/Sets): injectivity of Compacts.map Nov 12, 2025
@mathlib-bors mathlib-bors bot closed this Nov 12, 2025
thorimur pushed a commit to thorimur/mathlib4 that referenced this pull request Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants