[Merged by Bors] - chore(Trace/Quotient): move isomorphism to Localization.AtPrime.Basic#32045
Closed
xroblot wants to merge 6 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore(Trace/Quotient): move isomorphism to Localization.AtPrime.Basic#32045xroblot wants to merge 6 commits intoleanprover-community:masterfrom
Localization.AtPrime.Basic#32045xroblot wants to merge 6 commits intoleanprover-community:masterfrom
Conversation
PR summary b5631451f1Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
6 tasks
erdOne
reviewed
Dec 6, 2025
| /-- The isomorphism `R ⧸ p ≃+* Rₚ ⧸ maximalIdeal Rₚ`, where `Rₚ` satisfies | ||
| `IsLocalization.AtPrime Rₚ p`. In particular, localization preserves the residue field. -/ | ||
| noncomputable | ||
| def equivQuotMaximalIdeal : R ⧸ p ≃+* Rₚ ⧸ maximalIdeal Rₚ := by |
Member
There was a problem hiding this comment.
I think this should say ResidueField Rₚ ≃+* R ⧸ p. Or even be upgraded to a R-algebra iso.
Collaborator
Author
There was a problem hiding this comment.
I have made the other changes but I am not sure about doing this one in this PR since this PR is only intended for moving things around and this suggestion requires some more substantial changes.
Thanks for the review!
erdOne
added
the
awaiting-author
xroblot
removed
the
awaiting-author
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
ghost
added
the
maintainer-merge
Member
|
Thanks! bors merge |
ghost
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 13, 2025
…c` (#32045) This PR move isomorphisms previously defined in `Trace.Quotient` into `Localization.AtPrime.Basic`. The change is purely organizational: `Localization.AtPrime.Basic` is the canonical place for lemmas and constructions about localization at a prime. The isomorphisms are also renamed to match their new namespace: - `equivQuotMaximalIdealOfIsLocalization` -> `IsLocalization.AtPrime.equivQuotMaximalIdeal` - `quotMapEquivQuotMapMaximalIdealOfIsLocalization` -> `IsLocalization.AtPrime.equivQuotMapMaximalIdeal`
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Localization.AtPrime.BasicLocalization.AtPrime.Basic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR move isomorphisms previously defined in
Trace.QuotientintoLocalization.AtPrime.Basic. The change is purely organizational:Localization.AtPrime.Basicis the canonical place for lemmas and constructions about localization at a prime. The isomorphisms are also renamed to match their new namespace:equivQuotMaximalIdealOfIsLocalization->IsLocalization.AtPrime.equivQuotMaximalIdealquotMapEquivQuotMapMaximalIdealOfIsLocalization->IsLocalization.AtPrime.equivQuotMapMaximalIdeal