[Merged by Bors] - refactor(Analysis,Geometry): assume n ≠ 0, not 1 ≤ n#33131
[Merged by Bors] - refactor(Analysis,Geometry): assume n ≠ 0, not 1 ≤ n#33131urkud wants to merge 1 commit intoleanprover-community:masterfrom
n ≠ 0, not 1 ≤ n#33131Conversation
PR summary e9a7156e27Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
grunweg
left a comment
There was a problem hiding this comment.
Thanks for proposing this! Most changes are neutral, some are a bit nicer and other slightly more cumbersome to write. I agree that being able to use positivity is useful --- but I think this PR's convention should be documented somewhere. A new library note, perhaps?
Let me get another opinion, as this change is sufficiently far-reaching: CC @fpvandoorn @sgouezel @PatrickMassot
maintainer delegate?
| hasStrictFDerivAt_of_hasFDerivAt_of_continuousAt (hf.eventually_hasFDerivAt hn hs) <| | ||
| (continuousMultilinearCurryFin1 𝕂 E' F').continuousAt.comp <| (hf.cont 1 hn).continuousAt hs | ||
| (continuousMultilinearCurryFin1 𝕂 E' F').continuousAt.comp <| | ||
| (hf.cont 1 <| ENat.one_le_iff_ne_zero_withTop.mpr hn).continuousAt hs |
There was a problem hiding this comment.
Should this lemma also be changed? (There's another such instance somewhere below.)
There was a problem hiding this comment.
The lemma HasFTaylorSeriesUpTo.cont works for any (m : Nat) (hm : m ≤ n). When specialized to m = 1, it naturally requires a proof of 1 ≤ n.
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
I think that it goes along the general convention of assuming a seemingly weaker result. |
|
Thanks, I think this is a clear improvement. bors merge |
|
Pull request successfully merged into master. Build succeeded: |
n ≠ 0, not 1 ≤ nn ≠ 0, not 1 ≤ n
…community#33131) This way it's a `positivity` goal.
From leanprover-community#33633, leanprover-community#30563, leanprover-community#33771, leanprover-community#33755, leanprover-community#31988, leanprover-community#33622, leanprover-community#32837, leanprover-community#33638, leanprover-community#33503, leanprover-community#33321, leanprover-community#33242, leanprover-community#32955, leanprover-community#33159, leanprover-community#33152, leanprover-community#33131, leanprover-community#33144, leanprover-community#32116, leanprover-community#31259, leanprover-community#26831, leanprover-community#32917, leanprover-community#32589, leanprover-community#32584, leanprover-community#32562, leanprover-community#32788, and leanprover-community#32568.
From leanprover-community#33633, leanprover-community#30563, leanprover-community#33771, leanprover-community#33755, leanprover-community#31988, leanprover-community#33622, leanprover-community#32837, leanprover-community#33638, leanprover-community#33503, leanprover-community#33321, leanprover-community#33242, leanprover-community#32955, leanprover-community#33159, leanprover-community#33152, leanprover-community#33131, leanprover-community#33144, leanprover-community#32116, leanprover-community#31259, leanprover-community#26831, leanprover-community#32917, leanprover-community#32589, leanprover-community#32584, leanprover-community#32562, leanprover-community#32788, and leanprover-community#32568.
From leanprover-community#33633, leanprover-community#30563, leanprover-community#33771, leanprover-community#33755, leanprover-community#31988, leanprover-community#33622, leanprover-community#32837, leanprover-community#33638, leanprover-community#33503, leanprover-community#33321, leanprover-community#33242, leanprover-community#32955, leanprover-community#33159, leanprover-community#33152, leanprover-community#33131, leanprover-community#33144, leanprover-community#32116, leanprover-community#31259, leanprover-community#26831, leanprover-community#32917, leanprover-community#32589, leanprover-community#32584, leanprover-community#32562, leanprover-community#32788, and leanprover-community#32568.
…community#33131) This way it's a `positivity` goal.
From leanprover-community#33633, leanprover-community#30563, leanprover-community#33771, leanprover-community#33755, leanprover-community#31988, leanprover-community#33622, leanprover-community#32837, leanprover-community#33638, leanprover-community#33503, leanprover-community#33321, leanprover-community#33242, leanprover-community#32955, leanprover-community#33159, leanprover-community#33152, leanprover-community#33131, leanprover-community#33144, leanprover-community#32116, leanprover-community#31259, leanprover-community#26831, leanprover-community#32917, leanprover-community#32589, leanprover-community#32584, leanprover-community#32562, leanprover-community#32788, and leanprover-community#32568.
This way it's a
positivitygoal.