Skip to content

[Merged by Bors] - refactor(Analysis,Geometry): assume n ≠ 0, not 1 ≤ n#33131

Closed
urkud wants to merge 1 commit intoleanprover-community:masterfrom
urkud:one-le-vs-ne-zero
Closed

[Merged by Bors] - refactor(Analysis,Geometry): assume n ≠ 0, not 1 ≤ n#33131
urkud wants to merge 1 commit intoleanprover-community:masterfrom
urkud:one-le-vs-ne-zero

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Dec 20, 2025

This way it's a positivity goal.


Open in Gitpod

@urkud urkud requested a review from sgouezel December 20, 2025 17:06
@github-actions
Copy link
Copy Markdown

PR summary e9a7156e27

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

-+-+ mdifferentiable'
-+-+ mdifferentiableOn

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this! Most changes are neutral, some are a bit nicer and other slightly more cumbersome to write. I agree that being able to use positivity is useful --- but I think this PR's convention should be documented somewhere. A new library note, perhaps?

Let me get another opinion, as this change is sufficiently far-reaching: CC @fpvandoorn @sgouezel @PatrickMassot
maintainer delegate?

hasStrictFDerivAt_of_hasFDerivAt_of_continuousAt (hf.eventually_hasFDerivAt hn hs) <|
(continuousMultilinearCurryFin1 𝕂 E' F').continuousAt.comp <| (hf.cont 1 hn).continuousAt hs
(continuousMultilinearCurryFin1 𝕂 E' F').continuousAt.comp <|
(hf.cont 1 <| ENat.one_le_iff_ne_zero_withTop.mpr hn).continuousAt hs
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this lemma also be changed? (There's another such instance somewhere below.)

Copy link
Copy Markdown
Member Author

@urkud urkud Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lemma HasFTaylorSeriesUpTo.cont works for any (m : Nat) (hm : m ≤ n). When specialized to m = 1, it naturally requires a proof of 1 ≤ n.

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 20, 2025
@urkud
Copy link
Copy Markdown
Member Author

urkud commented Dec 20, 2025

Thanks for proposing this! Most changes are neutral, some are a bit nicer and other slightly more cumbersome to write. I agree that being able to use positivity is useful --- but I think this PR's convention should be documented somewhere. A new library note, perhaps?

Let me get another opinion, as this change is sufficiently far-reaching: CC @fpvandoorn @sgouezel @PatrickMassot maintainer delegate?

I think that it goes along the general convention of assuming a seemingly weaker result.

@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Dec 22, 2025

Thanks, I think this is a clear improvement.

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Dec 22, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 22, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 22, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(Analysis,Geometry): assume n ≠ 0, not 1 ≤ n [Merged by Bors] - refactor(Analysis,Geometry): assume n ≠ 0, not 1 ≤ n Dec 22, 2025
@mathlib-bors mathlib-bors bot closed this Dec 22, 2025
@urkud urkud deleted the one-le-vs-ne-zero branch December 29, 2025 14:34
kim-em pushed a commit to kim-em/mathlib4 that referenced this pull request Jan 6, 2026
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants