Skip to content

[Merged by Bors] - feat(RingTheory): Algebra.FinitePresentation descends along faithfully flat algebras#35254

Closed
chrisflav wants to merge 4 commits intoleanprover-community:masterfrom
chrisflav:descent-finpres
Closed

[Merged by Bors] - feat(RingTheory): Algebra.FinitePresentation descends along faithfully flat algebras#35254
chrisflav wants to merge 4 commits intoleanprover-community:masterfrom
chrisflav:descent-finpres

Conversation

@chrisflav
Copy link
Copy Markdown
Member

From Pi1.


Open in Gitpod

@chrisflav chrisflav added the t-ring-theory Ring theory label Feb 13, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 13, 2026

PR summary 8ca4eacd8c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.RingTheory.Finiteness.Descent (new file) 1953

Declarations diff

+ Algebra.TensorProduct.commRight_symm_tmul
+ Finite.codescendsAlong_faithfullyFlat
+ FinitePresentation.codescendsAlong_faithfullyFlat
+ FinitePresentation.of_finitePresentation_tensorProduct_of_faithfullyFlat
+ FiniteType.codescendsAlong_faithfullyFlat
+ FiniteType.of_finiteType_tensorProduct_of_faithfullyFlat
+ Ideal.FG.of_FG_map_of_faithfullyFlat
+ Module.Finite.of_finite_tensorProduct_of_faithfullyFlat
+ commRight
+ commRight_tmul
+ exists_sum_tmul_eq

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Comment thread Mathlib/RingTheory/Finiteness/Descent.lean
Comment thread Mathlib/RingTheory/TensorProduct/Maps.lean
Copy link
Copy Markdown
Member

@erdOne erdOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@erdOne
Copy link
Copy Markdown
Member

erdOne commented Feb 13, 2026

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by erdOne.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Feb 13, 2026
@joelriou
Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Feb 13, 2026
mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 13, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory): Algebra.FinitePresentation descends along faithfully flat algebras [Merged by Bors] - feat(RingTheory): Algebra.FinitePresentation descends along faithfully flat algebras Feb 13, 2026
@mathlib-bors mathlib-bors bot closed this Feb 13, 2026
kim-em pushed a commit to kim-em/mathlib4 that referenced this pull request Feb 14, 2026
rao107 pushed a commit to rao107/mathlib4 that referenced this pull request Feb 18, 2026
Maldooor pushed a commit to Maldooor/mathlib4 that referenced this pull request Feb 25, 2026
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants