Skip to content

[Merged by Bors] - feat(AlgebraicGeometry): abelian varieties are abelian#35354

Closed
erdOne wants to merge 57 commits intoleanprover-community:masterfrom
erdOne:erd1/AbelianScheme
Closed

[Merged by Bors] - feat(AlgebraicGeometry): abelian varieties are abelian#35354
erdOne wants to merge 57 commits intoleanprover-community:masterfrom
erdOne:erd1/AbelianScheme

Conversation

@erdOne
Copy link
Copy Markdown
Member

@erdOne erdOne commented Feb 15, 2026

We show that proper geometrically-integral group schemes over fields are commutative.

Co-authored-by: Christian Merten


Open in Gitpod

erdOne and others added 30 commits February 9, 2026 13:42
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Co-authored-by: Christian Merten <christian@merten.dev>
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Feb 15, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 15, 2026

PR summary 330d0ae2dc

Import changes exceeding 2%

% File
+3.61% Mathlib.AlgebraicGeometry.Noetherian

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.AlgebraicGeometry.Noetherian 2297 2380 +83 (+3.61%)
Import changes for all files
Files Import difference
Mathlib.AlgebraicGeometry.Morphisms.QuasiFinite 22
Mathlib.AlgebraicGeometry.Geometrically.Reduced 57
Mathlib.AlgebraicGeometry.Artinian 64
3 files Mathlib.AlgebraicGeometry.Noetherian Mathlib.AlgebraicGeometry.RationalMap Mathlib.AlgebraicGeometry.SpreadingOut
83
Mathlib.AlgebraicGeometry.Group.Abelian (new file) 2759

Declarations diff

+ Functor.map_inv'
+ JacobsonSpace.closure_inter_closedPoints_eq_closure
+ LocallyOfFinitePresentation.iff_locallyOfFiniteType
+ Set.Finite.isDiscrete_of_subset_closedPoints
+ ext_of_apply_closedPoint_eq
+ ext_of_apply_eq
+ ext_of_fromSpecResidueField_eq
+ fst_left
+ instance (G : Over (Spec (.of K))) [GrpObj G] : IsClosedImmersion η[G].left
+ instance (priority := low) [Nonempty X] [Subsingleton Y] (f : X ⟶ Y) :
+ instance (priority := low) {X Y : Scheme} (f : X ⟶ Y)
+ instance {X Y : Scheme} (f : X ⟶ Y) [Surjective f] [Flat f] [LocallyOfFinitePresentation f] :
+ instance {X Y : Scheme} (f : X ⟶ Y) [Surjective f] [Flat f] [QuasiCompact f] :
+ isCommMonObj_of_isProper_of_geometricallyIntegral
+ isCommMonObj_of_isProper_of_isIntegral_tensorObj_of_isAlgClosed
+ snd_left
+ subsingleton_image_closure_of_finite_of_isPreirreducible
++ instance {X Y S : Scheme} (f : X ⟶ S) (g : Y ⟶ S)

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 15, 2026
@github-actions github-actions bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Feb 15, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 15, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Feb 15, 2026
@erdOne erdOne added the t-algebraic-geometry Algebraic geometry label Feb 15, 2026
Comment thread Mathlib/AlgebraicGeometry/Group/Abelian.lean
Comment thread Mathlib/AlgebraicGeometry/Group/Abelian.lean
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@CBirkbeck CBirkbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a looks really great, thanks for doing it! (I dont really have any serious comments on the PR other than tiny things I noticed)

Comment thread Mathlib/AlgebraicGeometry/AlgClosed/Basic.lean Outdated
Comment thread Mathlib/AlgebraicGeometry/Group/Abelian.lean Outdated
Comment thread Mathlib/AlgebraicGeometry/Group/Abelian.lean Outdated
@jcommelin
Copy link
Copy Markdown
Member

Thanks 🎉

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Feb 17, 2026
mathlib-bors bot pushed a commit that referenced this pull request Feb 17, 2026
We show that proper geometrically-integral group schemes over fields are commutative.

Co-authored-by: Christian Merten
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Christian Merten <christian@merten.dev>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 17, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(AlgebraicGeometry): abelian varieties are abelian [Merged by Bors] - feat(AlgebraicGeometry): abelian varieties are abelian Feb 17, 2026
@mathlib-bors mathlib-bors bot closed this Feb 17, 2026
Maldooor pushed a commit to Maldooor/mathlib4 that referenced this pull request Feb 25, 2026
…mmunity#35354)

We show that proper geometrically-integral group schemes over fields are commutative.

Co-authored-by: Christian Merten
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Christian Merten <christian@merten.dev>
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Mar 2, 2026
…mmunity#35354)

We show that proper geometrically-integral group schemes over fields are commutative.

Co-authored-by: Christian Merten
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Christian Merten <christian@merten.dev>
@YaelDillies YaelDillies deleted the erd1/AbelianScheme branch April 3, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports ready-to-merge This PR has been sent to bors. t-algebraic-geometry Algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants