feat(FinitelyPresentedGroup): add FreeGroup instance#36508
Draft
homeowmorphism wants to merge 166 commits intoleanprover-community:masterfrom
Draft
feat(FinitelyPresentedGroup): add FreeGroup instance#36508homeowmorphism wants to merge 166 commits intoleanprover-community:masterfrom
homeowmorphism wants to merge 166 commits intoleanprover-community:masterfrom
Conversation
- Add equivalence lemmas (incomplete) - Add basic instances (incomplete) Working on: isFinitelyPresented_iff_finite_set forward direction
- Add equivalence lemmas (incomplete) - Add basic instances (incomplete) Working on: isFinitelyPresented_iff_finite_set forward direction
…NormalClosureOfFiniteSet f'.ker`. Draft until I can figure out cleaner ways to do it.
…s more descriptive for groups.
…er_comp_mulEquiv` lemma.
…f (wip) and recovered instance
…stead of `α : Type`.
…ntedGroup G` draft human pf
mathlib-dependent-issues
bot
added
the
blocked-by-other-PR
mathlib-merge-conflicts
bot
added
the
merge-conflict
|
This pull request has conflicts, please merge |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
github-actions
bot
removed
the
merge-conflict
There was a problem hiding this comment.
Pull request overview
This PR introduces a new GroupTheory module formalizing finitely presented groups and basic closure/characterization lemmas, and then re-exports it from the umbrella Mathlib import.
Changes:
- Add
Mathlib/GroupTheory/FinitelyPresentedGroup.leandefiningIsNormalClosureFGand the typeclassIsFinitelyPresented, plus several equivalence/transfer lemmas. - Add a
Group.FGinstance for finitely presented groups. - Re-export the new module via
Mathlib.lean.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| Mathlib/GroupTheory/FinitelyPresentedGroup.lean | New module defining finitely presented groups and proving equivalences/closure results. |
| Mathlib.lean | Adds the new module to the global import list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Mar 19, 2026
Contributor
|
This pull request is now in draft mode. No active bors state needed cleanup. While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like |
|
This pull request has conflicts, please merge |
mathlib-merge-conflicts
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
Contributor
Author
mathlib-dependent-issues
bot
removed
the
blocked-by-other-PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds free group instances of finitely presented group.