Skip to content

[Merged by Bors] - feat(RefinedDiscrTree/Lookup): use parallellism in lookup#36992

Closed
JovanGerb wants to merge 4 commits intoleanprover-community:masterfrom
JovanGerb:Jovan-RefinedDiscrTree-lookup-parallel
Closed

[Merged by Bors] - feat(RefinedDiscrTree/Lookup): use parallellism in lookup#36992
JovanGerb wants to merge 4 commits intoleanprover-community:masterfrom
JovanGerb:Jovan-RefinedDiscrTree-lookup-parallel

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

This PR adds parallellism to the RefinedDiscrTree lookup. Previously, only constructing the root node of the discrimination tree used parallellism. But it turns out some of the child nodes can be pretty big too.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 22, 2026

PR summary 3d8100bbc6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ processPending

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-meta Tactics, attributes or user commands label Mar 22, 2026
Copy link
Copy Markdown
Contributor

@adamtopaz adamtopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay...

@adamtopaz adamtopaz added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 3, 2026
@JovanGerb JovanGerb removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 13, 2026
@adamtopaz
Copy link
Copy Markdown
Contributor

bors r+

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 14, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 14, 2026
This PR adds parallellism to the `RefinedDiscrTree` lookup. Previously, only constructing the root node of the discrimination tree used parallellism. But it turns out some of the child nodes can be pretty big too.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 14, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RefinedDiscrTree/Lookup): use parallellism in lookup [Merged by Bors] - feat(RefinedDiscrTree/Lookup): use parallellism in lookup Apr 14, 2026
@mathlib-bors mathlib-bors bot closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants