Skip to content

[Merged by Bors] - feat: Complex.tan, Complex.tanh are meromorphic#37327

Closed
ldct wants to merge 11 commits intoleanprover-community:masterfrom
ldct:ldct-mero
Closed

[Merged by Bors] - feat: Complex.tan, Complex.tanh are meromorphic#37327
ldct wants to merge 11 commits intoleanprover-community:masterfrom
ldct:ldct-mero

Conversation

@ldct
Copy link
Copy Markdown
Collaborator

@ldct ldct commented Mar 29, 2026

From AlexKontorovich/PrimeNumberTheoremAnd project


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2026

PR summary f7c1d6ebc9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Analysis.SpecialFunctions.Trigonometric.Meromorphic (new file) 2007

Declarations diff

+ MeromorphicNFOn.div
+ meromorphicAt_tan
+ meromorphicAt_tanh
+ meromorphicNFOn_tan
+ meromorphicNFOn_tanh
+ meromorphic_tan
+ meromorphic_tanh

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Mar 29, 2026
ldct and others added 3 commits March 28, 2026 22:16
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ldct ldct marked this pull request as ready for review March 29, 2026 21:56
@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 31, 2026
@j-loreaux
Copy link
Copy Markdown
Contributor

I agree with Monica here.

@ldct ldct removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 3, 2026
ldct and others added 2 commits April 3, 2026 15:08
@themathqueen
Copy link
Copy Markdown
Collaborator

I think you need to merge master to fix the CI-error.

Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also show MeromorphicNFOn for both of these? It should be straightforward since they are both quotients of analytic functions, although I think the key lemma doesn't exist yet in the right form. It would be something like:

AnalyticAt 𝕜 f x → MeromorphicNFAt 𝕜 g x → (g x ≠ 0 ∨ f x ≠ 0) → MeromorphicNFAt 𝕜 (f / g) x

This should follow from MeromorphicNFAt.inv and meromorphicNFAt_mul_iff_left plus a little but of extra work.

@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 7, 2026
@ldct ldct removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 10, 2026
Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 14, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 14, 2026
From `AlexKontorovich/PrimeNumberTheoremAnd` project

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 14, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Complex.tan, Complex.tanh are meromorphic [Merged by Bors] - feat: Complex.tan, Complex.tanh are meromorphic Apr 14, 2026
@mathlib-bors mathlib-bors bot closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants