Skip to content

[Merged by Bors] - feat(Topology/Order): add IsMax.of_disjoint_nhds_Ioi, IsMin.of_disjoint_nhds_Iio, nonempty_nhds_inter_Ioi, nonempty_nhds_inter_Iio#37550

Closed
pitmonticone wants to merge 3 commits intoleanprover-community:masterfrom
pitmonticone:carleson/nonempty-nhds-inter-Ioi
Closed

[Merged by Bors] - feat(Topology/Order): add IsMax.of_disjoint_nhds_Ioi, IsMin.of_disjoint_nhds_Iio, nonempty_nhds_inter_Ioi, nonempty_nhds_inter_Iio#37550
pitmonticone wants to merge 3 commits intoleanprover-community:masterfrom
pitmonticone:carleson/nonempty-nhds-inter-Ioi

Conversation

@pitmonticone
Copy link
Copy Markdown
Member

@pitmonticone pitmonticone commented Apr 2, 2026

Add nonempty_nhds_inter_Ioi: a neighborhood of x has nonempty intersection with Ioi x when x is not a maximum.

Upstreamed from the Carleson project.

Co-authored-by: Leo Diedering 129694072+ldiedering@users.noreply.github.com
Co-authored-by: Michael Rothgang rothgang@math.uni-bonn.de

@pitmonticone pitmonticone added carleson part of the ongoing formalization of Carleson's theorem easy < 20s of review time. See the lifecycle page for guidelines. labels Apr 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026 •
edited
Loading

PR summary 49358d7352

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsMax.of_disjoint_nhds_Ioi
+ IsMin.of_disjoint_nhds_Iio
+ nonempty_nhds_inter_Iio
+ nonempty_nhds_inter_Ioi

You can run this locally as follows 
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Apr 2, 2026
@pitmonticone pitmonticone mentioned this pull request Apr 2, 2026
Merged
ADedecker
ADedecker reviewed Apr 3, 2026
View reviewed changes
@ADedecker ADedecker added awaiting-author A reviewer has asked the author a question or requested changes. and removed easy < 20s of review time. See the lifecycle page for guidelines. labels Apr 3, 2026
@pitmonticone pitmonticone force-pushed the carleson/nonempty-nhds-inter-Ioi branch from 9a33522 to e9fdbae Compare April 3, 2026 10:30
@pitmonticone
Copy link
Copy Markdown
Member Author

pitmonticone commented Apr 3, 2026

Ok, thanks! Moved to DenselyOrdered, reproved via closure_Ioi' + mem_closure_iff_nhds, and added nonempty_nhds_inter_Iio.

@pitmonticone @ldiedering @grunweg
feat(Topology/Order): add nonempty_nhds_inter_Ioi and `nonempty_nhd…
bac20da 
…s_inter_Iio`

Add `nonempty_nhds_inter_Ioi` and `nonempty_nhds_inter_Iio`: a neighborhood of `x` has nonempty intersection with `Ioi x` (resp. `Iio x`) when `x` is not a maximum (resp. minimum).

Upstreamed from the [Carleson](https://github.com/fpvandoorn/carleson) project.

Co-authored-by: Leo Diedering <129694072+ldiedering@users.noreply.github.com>
Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
@pitmonticone pitmonticone force-pushed the carleson/nonempty-nhds-inter-Ioi branch from e9fdbae to bac20da Compare April 3, 2026 10:39
@pitmonticone pitmonticone removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 3, 2026
eric-wieser
eric-wieser reviewed Apr 5, 2026
View reviewed changes
@pitmonticone pitmonticone force-pushed the carleson/nonempty-nhds-inter-Ioi branch from 555981b to 720841a Compare April 5, 2026 19:53
@pitmonticone
Copy link
Copy Markdown
Member Author

pitmonticone commented Apr 5, 2026 •
edited
Loading

Good idea, thanks @eric-wieser! Added IsMax.of_disjoint_nhds_Ioi and IsMin.of_disjoint_nhds_Iio, and derived the nonempty versions from them.

Is it ok now?

@pitmonticone pitmonticone changed the title feat(Topology/Order): add nonempty_nhds_inter_Ioi feat(Topology/Order): add IsMax.of_disjoint_nhds_Ioi, IsMin.of_disjoint_nhds_Iio, nonempty_nhds_inter_Ioi, nonempty_nhds_inter_Iio Apr 5, 2026
fpvandoorn
fpvandoorn reviewed Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Apr 7, 2026
@pitmonticone @ldiedering @grunweg
feat(Topology/Order): add IsMax.of_disjoint_nhds_Ioi, `IsMin.of_dis…
7b476a1 
…joint_nhds_Iio`, `nonempty_nhds_inter_Ioi`, `nonempty_nhds_inter_Iio` (#37550)

Add `nonempty_nhds_inter_Ioi`: a neighborhood of `x` has nonempty intersection with `Ioi x` when `x` is not a maximum.

Upstreamed from the [Carleson](https://github.com/fpvandoorn/carleson) project.

Co-authored-by: Leo Diedering <129694072+ldiedering@users.noreply.github.com>
Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 7, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 7, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/Order): add IsMax.of_disjoint_nhds_Ioi, IsMin.of_disjoint_nhds_Iio, nonempty_nhds_inter_Ioi, nonempty_nhds_inter_Iio [Merged by Bors] - feat(Topology/Order): add IsMax.of_disjoint_nhds_Ioi, IsMin.of_disjoint_nhds_Iio, nonempty_nhds_inter_Ioi, nonempty_nhds_inter_Iio Apr 7, 2026
@mathlib-bors mathlib-bors bot closed this Apr 7, 2026
fpvandoorn pushed a commit to fpvandoorn/carleson that referenced this pull request Apr 7, 2026
@pitmonticone
chore(ToMathlib): note upstreaming status for 8 files (#548)
9ac500b 
Update the upstreaming status comments for files that have been PRed to
mathlib:

- `Analysis/MeanInequalitiesPow`
leanprover-community/mathlib4#37547
- `Order/LiminfLimsup`
leanprover-community/mathlib4#37549 (merged)
- `Topology/Order/Basic`
leanprover-community/mathlib4#37550 (moved to
DenselyOrdered)
- `MeasureTheory/Integral/Average`
leanprover-community/mathlib4#37551
- `MeasureTheory/Measure/ENNReal`
leanprover-community/mathlib4#37552 (generalized
to `measurable_iSup_of_lowerSemicontinuous`)
- `MeasureTheory/Integral/Lebesgue`
leanprover-community/mathlib4#37558 (merged)
- `MeasureTheory/Function/LpSpace/Indicator`
leanprover-community/mathlib4#37559
- `MeasureTheory/Function/LpSpace/ContinuousFunctions`
leanprover-community/mathlib4#37560
- `Data/ENNReal`
leanprover-community/mathlib4#37565 (partial)
- `MeasureTheory/Integral/Bochner/ContinuousLinearMap`
leanprover-community/mathlib4#37568 (partial)
- `Topology/Instances/AddCircle/Defs`
leanprover-community/mathlib4#37570 (partial)
- `Discrete/SumEstimates`
leanprover-community/mathlib4#37597

Also notes that `IntegrableAtFilter.congr` and
`integrableOn_of_integrableOn_inter_support` already exist in mathlib.
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Apr 10, 2026
@pitmonticone @ldiedering
@grunweg @xroblot
feat(Topology/Order): add IsMax.of_disjoint_nhds_Ioi, `IsMin.of_dis…
9eab545 
…joint_nhds_Iio`, `nonempty_nhds_inter_Ioi`, `nonempty_nhds_inter_Iio` (leanprover-community#37550)

Add `nonempty_nhds_inter_Ioi`: a neighborhood of `x` has nonempty intersection with `Ioi x` when `x` is not a maximum.

Upstreamed from the [Carleson](https://github.com/fpvandoorn/carleson) project.

Co-authored-by: Leo Diedering <129694072+ldiedering@users.noreply.github.com>
Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@fpvandoorn fpvandoorn fpvandoorn left review comments

@ADedecker ADedecker ADedecker left review comments

Assignees

@urkud urkud

Labels

carleson part of the ongoing formalization of Carleson's theorem ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pitmonticone @eric-wieser @fpvandoorn @ADedecker @urkud
⚡