Skip to content

feat(Topology/Algebra/Group/Matrix): refactor; continuity of maps on GL(n) and SL(n)#37601

Open
loefflerd wants to merge 3 commits intoleanprover-community:masterfrom
loefflerd:DL_cleanup_matrixtop
Open

feat(Topology/Algebra/Group/Matrix): refactor; continuity of maps on GL(n) and SL(n)#37601
loefflerd wants to merge 3 commits intoleanprover-community:masterfrom
loefflerd:DL_cleanup_matrixtop

Conversation

@loefflerd
Copy link
Copy Markdown
Contributor

@loefflerd loefflerd commented Apr 3, 2026

Show that the maps Rˣ → Sˣ, SL n R → SL n S, and GL n R → GL n S induced by a ring/monoid morphism f : R → S are continuous / inducing / embedding / closed-embedding if f is.

Also add Real analogues of some existing Complex lemmas about the intCast map, e.g. Real.closedEmbedding_intCast, and refactor and clean up Topology/Algebra/Group/Matrix.lean.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

PR summary 1ba90ab6bb

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Topology.IsClosedEmbedding.prodMap
+ _root_.Continuous.generalLinearGroup_map
+ _root_.Continuous.specialLinearGroup_map
+ _root_.Topology.IsClosedEmbedding.generalLinearGroup_map
+ _root_.Topology.IsClosedEmbedding.specialLinearGroup_map
+ _root_.Topology.IsClosedEmbedding.units_map
+ _root_.Topology.IsEmbedding.generalLinearGroup_map
+ _root_.Topology.IsEmbedding.specialLinearGroup_map
+ _root_.Topology.IsEmbedding.units_map
+ _root_.Topology.IsInducing.generalLinearGroup_map
+ _root_.Topology.IsInducing.specialLinearGroup_map
+ _root_.Topology.IsInducing.units_map
+ closedEmbedding_intCast
+ continuous_mapGL
+ instT1Space
+ isClosedEmbedding_mapGL
+ isClosed_range_intCast
+ isOpen_compl_range_intCast
+ isometry_intCast

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (2.00, 0.00)
Current number Change Type
6869 -2 backward.isDefEq.respectTransparency

Current commit bb444b6098
Reference commit 1ba90ab6bb

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 4, 2026
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 6, 2026
theorem isometry_intCast : Isometry ((↑) : ℤ → ℝ) :=
Isometry.of_dist_eq <| by tauto

theorem closedEmbedding_intCast : IsClosedEmbedding ((↑) : ℤ → ℝ) :=
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
theorem closedEmbedding_intCast : IsClosedEmbedding ((↑) : ℤ → ℝ) :=
theorem isClosedEmbedding_intCast : IsClosedEmbedding ((↑) : ℤ → ℝ) :=

Comment on lines +170 to +172
lemma continuous_mapGL (h : Continuous (algebraMap R S)) :
Continuous (mapGL S : SL n R → _) :=
continuous_toGL.comp h.specialLinearGroup_map
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continuous (algebraMap R S) (with the pre-existing hypotheses) is equivalent to ContinuousSMul R S (see continuous_algebraMap_iff_smul). I suggest assuming ContinuousSMul R S instead so that the user does not need to supply this hypothesis.

Comment on lines +229 to 230
@[fun_prop]
lemma continuous (hf : IsEmbedding f) : Continuous f := hf.isInducing.continuous
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 are we sure about this? This creates a bridge between layers in the fun_prop hierarchy. That is, IsEmbedding → IsInducing → Continuous already existed, but now you're adding a direct line. The net effect, because fun_prop by default only tries depth-1 transitions. So, by adding this, you're making it try certain things that would previously have been depth-2. I suspect that's not what we want.

@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants