feat(Topology/Algebra/Group/Matrix): refactor; continuity of maps on GL(n) and SL(n)#37601
feat(Topology/Algebra/Group/Matrix): refactor; continuity of maps on GL(n) and SL(n)#37601loefflerd wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
PR summary 1ba90ab6bbImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 6869 | -2 | backward.isDefEq.respectTransparency |
Current commit bb444b6098
Reference commit 1ba90ab6bb
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
This pull request has conflicts, please merge |
| theorem isometry_intCast : Isometry ((↑) : ℤ → ℝ) := | ||
| Isometry.of_dist_eq <| by tauto | ||
|
|
||
| theorem closedEmbedding_intCast : IsClosedEmbedding ((↑) : ℤ → ℝ) := |
There was a problem hiding this comment.
| theorem closedEmbedding_intCast : IsClosedEmbedding ((↑) : ℤ → ℝ) := | |
| theorem isClosedEmbedding_intCast : IsClosedEmbedding ((↑) : ℤ → ℝ) := |
| lemma continuous_mapGL (h : Continuous (algebraMap R S)) : | ||
| Continuous (mapGL S : SL n R → _) := | ||
| continuous_toGL.comp h.specialLinearGroup_map |
There was a problem hiding this comment.
Continuous (algebraMap R S) (with the pre-existing hypotheses) is equivalent to ContinuousSMul R S (see continuous_algebraMap_iff_smul). I suggest assuming ContinuousSMul R S instead so that the user does not need to supply this hypothesis.
| @[fun_prop] | ||
| lemma continuous (hf : IsEmbedding f) : Continuous f := hf.isInducing.continuous |
There was a problem hiding this comment.
🤔 are we sure about this? This creates a bridge between layers in the fun_prop hierarchy. That is, IsEmbedding → IsInducing → Continuous already existed, but now you're adding a direct line. The net effect, because fun_prop by default only tries depth-1 transitions. So, by adding this, you're making it try certain things that would previously have been depth-2. I suspect that's not what we want.
Show that the maps
Rˣ → Sˣ,SL n R → SL n S, andGL n R → GL n Sinduced by a ring/monoid morphismf : R → Sare continuous / inducing / embedding / closed-embedding iffis.Also add
Realanalogues of some existingComplexlemmas about theintCastmap, e.g.Real.closedEmbedding_intCast, and refactor and clean upTopology/Algebra/Group/Matrix.lean.