Skip to content

[Merged by Bors] - feat(Topology/Convenient): X-continuous maps#37792

Closed
joelriou wants to merge 5 commits intoleanprover-community:masterfrom
joelriou:continuous-map-generated-by
Closed

[Merged by Bors] - feat(Topology/Convenient): X-continuous maps#37792
joelriou wants to merge 5 commits intoleanprover-community:masterfrom
joelriou:continuous-map-generated-by

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Apr 8, 2026

This is a follow-up PR to #29341. In this PR, given a family X i of topological spaces, we introduce the notion of X-continuous maps: a map g : Y ⟶ Z is X-continuous if for any continuous map f : X i → Y, the composition g ∘ f is continuous. We provide both a predicate ContinuousGeneratedBy on maps Y → Z and a bundled type ContinuousMapGeneratedBy of X-continuous maps from Y to Z, as this shall be the type of morphisms in a category that is defined in #37799.

From https://github.com/joelriou/topcat-model-category


Open in Gitpod

@joelriou joelriou added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Apr 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

PR summary 00dbc4ec64

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Topology.Convenient.ContinuousMapGeneratedBy (new file) 690

Declarations diff

+ Continuous.continuousGeneratedBy
+ ContinuousGeneratedBy
+ ContinuousGeneratedBy.comp
+ ContinuousGeneratedBy.continuousMap
+ ContinuousGeneratedBy.continuousMap_coe
+ ContinuousGeneratedBy.id
+ ContinuousMapGeneratedBy
+ ContinuousMapGeneratedBy.comp
+ ContinuousMapGeneratedBy.id
+ continuousGeneratedBy_def
+ continuousGeneratedBy_iff
+ equivAsContinuousMapGeneratedBy
+ equivAsContinuousMapGeneratedBy_coe
+ equivSymmAsContinuousMapGeneratedBy
+ equivSymmAsContinuousMapGeneratedBy_coe
+ instance : FunLike (ContinuousMapGeneratedBy X Y Z) Y Z

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Collaborator

@scholzhannah scholzhannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! This looks good to me.

Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally opposed to this, but can you please explain (perhaps in the PR description) why we want all three of these? That is, with this PR we would now have:

  1. the type synonym WithGeneratedByTopology
  2. the predicate ContinuousGeneratedBy
  3. the subtype ContinuousMapGeneratedBy (technically a structure, but morally a subtype).

@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 14, 2026
@joelriou
Copy link
Copy Markdown
Contributor Author

I'm not totally opposed to this, but can you please explain (perhaps in the PR description) why we want all three of these? That is, with this PR we would now have:

1. the _type synonym_ `WithGeneratedByTopology`

2. the _predicate_ `ContinuousGeneratedBy`

3. the _subtype_ `ContinuousMapGeneratedBy` (technically a `structure`, but morally a subtype).

@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 14, 2026
@j-loreaux
Copy link
Copy Markdown
Contributor

Great, thanks for the explanation!

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 14, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 14, 2026
This is a follow-up PR to #29341. In this PR, given a family `X i` of topological spaces, we introduce the notion of `X`-continuous maps: a map `g : Y ⟶ Z` is `X`-continuous if for any continuous map `f : X i → Y`, the composition `g ∘ f` is continuous. We provide both a predicate `ContinuousGeneratedBy` on maps `Y → Z` and a bundled type `ContinuousMapGeneratedBy` of `X`-continuous maps from `Y` to `Z`, as this shall be the type of morphisms in a category that is defined in #37799.

From https://github.com/joelriou/topcat-model-category
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 14, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/Convenient): X-continuous maps [Merged by Bors] - feat(Topology/Convenient): X-continuous maps Apr 14, 2026
@mathlib-bors mathlib-bors bot closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants