feat: Module theory theorems#37893
feat: Module theory theorems#37893abeldonate wants to merge 12 commits intoleanprover-community:masterfrom
Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary 6bc2280e53Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| · rw [mem_torsionOf_iff, smul_eq_zero] at hr | ||
| tauto | ||
|
|
||
| @[simp] |
There was a problem hiding this comment.
As the CI error shows, this breaks simp in some other files so it might not be a good global simp lemma
There was a problem hiding this comment.
I think it broke some other files because of the namespace I was using, now it should be fixed.
scholzhannah
left a comment
There was a problem hiding this comment.
Thank you for your PR! I have left some comments on style.
| torsionOf R M x = (Submodule.span R ({x} : Set M)).annihilator := by | ||
| have := (Submodule.annihilator_span_singleton (R := R) (M := M) x).symm | ||
| simpa [torsionOf] |
There was a problem hiding this comment.
| torsionOf R M x = (Submodule.span R ({x} : Set M)).annihilator := by | |
| have := (Submodule.annihilator_span_singleton (R := R) (M := M) x).symm | |
| simpa [torsionOf] | |
| torsionOf R M x = (Submodule.span R ({x} : Set M)).annihilator := | |
| (Submodule.annihilator_span_singleton x).symm |
I'm not 100% sure if we want this lemma given that it is just restating Submodule.annihilator_span_singleton but I think it is probably still useful for discoverability.
Co-authored-by: Hannah Scholz <70071345+scholzhannah@users.noreply.github.com>
Co-authored-by: Hannah Scholz <70071345+scholzhannah@users.noreply.github.com>
Added three theorems: