-
Notifications
You must be signed in to change notification settings - Fork 1.2k
perf(Algebra/Ring): faster Ring.toAddGroupWithOne instance #38017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kbuzzard
wants to merge
7
commits into
leanprover-community:master
Choose a base branch
from
kbuzzard:kbuzzard-ring-to-addgroupwithone
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a1fe077
perf(Algebra/Ring): faster Ring.toAddGroupWithOne instance
kbuzzard 9a7e8db
remove unneeded import
kbuzzard 283b258
make Field.toSemifield a fast instance
kbuzzard 75e2fcf
more fast (or faster) instances
kbuzzard 8b69a34
fix Mathlib.Analysis.CStarAlgebra.Matrix
kbuzzard 0b79ad9
AddGroupWithOne.toAddMonoidWithOne'
kbuzzard 85699fc
Merge branch 'master' into kbuzzard-ring-to-addgroupwithone
kbuzzard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -145,6 +145,13 @@ class Semiring (α : Type u) extends NonUnitalSemiring α, NonAssocSemiring α, | |
| /-- A `Ring` is a `Semiring` with negation making it an additive group. -/ | ||
| class Ring (R : Type u) extends Semiring R, AddCommGroup R, AddGroupWithOne R | ||
|
|
||
| attribute [-instance] Ring.toAddGroupWithOne | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This only disables it for this file / section, it doesn't propagate to downstream files. |
||
|
|
||
| instance Ring.toAddGroupWithOne' (R : Type u) [Ring R] : AddGroupWithOne R := | ||
| @AddGroupWithOne.mk R Ring.toIntCast inferInstance inferInstance | ||
| inferInstance Ring.sub_eq_add_neg Ring.zsmul Ring.zsmul_zero' Ring.zsmul_succ' | ||
| Ring.zsmul_neg' Ring.neg_add_cancel intCast_ofNat intCast_negSucc | ||
|
|
||
| /-! | ||
| ### Semirings | ||
| -/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might have better luck with
and removing your other changes in this file.