feat(Algebra): expand Subalgebra.restrictScalars API#38018
Open
matthewjasper wants to merge 1 commit intoleanprover-community:masterfrom
Open
feat(Algebra): expand Subalgebra.restrictScalars API#38018matthewjasper wants to merge 1 commit intoleanprover-community:masterfrom
matthewjasper wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary 00dbc4ec64Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 6412 | -3 | backward.isDefEq.respectTransparency |
Current commit 988f6f43ac
Reference commit 00dbc4ec64
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
2d0555b to
988f6f4
Compare
eric-wieser
reviewed
Apr 13, 2026
Comment on lines
+125
to
+131
| toFun s := | ||
| let ⟨u, hu⟩ := algebraMap S U s | ||
| ⟨u, by rwa [mem_restrictScalars]⟩ | ||
| map_zero' := by ext; simp | ||
| map_one' := by ext; simp | ||
| map_add' x y := by ext; simp | ||
| map_mul' x y := by ext; simp |
Member
There was a problem hiding this comment.
Can you use something like RingHom.restrict here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an instance for the original algebra structure, the implied scalar tower instances, and the algebra equivalence with the original subalgebra. Use this to remove some
set_option backward.isDefEq.respectTransparency.