Skip to content

[Merged by Bors] - chore(Tactic/Linter): unicode linter documentation improvements#38019

Closed
adomasbaliuka wants to merge 5 commits intoleanprover-community:masterfrom
adomasbaliuka:patch-2
Closed

[Merged by Bors] - chore(Tactic/Linter): unicode linter documentation improvements#38019
adomasbaliuka wants to merge 5 commits intoleanprover-community:masterfrom
adomasbaliuka:patch-2

Conversation

@adomasbaliuka
Copy link
Copy Markdown
Collaborator

@adomasbaliuka adomasbaliuka commented Apr 13, 2026

As planned in #36773, we add a link to the style guide, which was updated at leanprover-community/leanprover-community.github.io#820.

Further changes:

  • some more documentation updates (some obsolete comments were talking about a "blocklist" which no longer exists)
  • change order of checks in isAllowedCharacter. The new order is more logical and may slightly improve performance (which probably doesn't matter) since Mathlib has more characters in otherInMathlib than emojis.

I linked to the file in the GitHub repo, not the website, so people can immediately edit the content when needed.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 13, 2026

PR summary 00dbc4ec64

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@adomasbaliuka adomasbaliuka changed the title doc(Tactic/Linter): linke to style guide from unicode linter doc(Tactic/Linter): link to style guide from unicode linter Apr 13, 2026
@github-actions github-actions bot added the t-linter Linter label Apr 13, 2026
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected a link to the webpage, but the rendered link on github looks pretty enough. Thanks!
bors d+

@mathlib-triage mathlib-triage bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Apr 14, 2026
adomasbaliuka and others added 4 commits April 14, 2026 12:31
Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
The new order seems more logical and would also improve performance (which probably doesn't matter) since Mathlib has more characters in otherInMathlib than emojis
@adomasbaliuka
Copy link
Copy Markdown
Collaborator Author

I made some more doc changes.

@grunweg Sorry for the question but how can I look at the modified website? Do I have to clone https://github.com/leanprover-community/mathlib4_docs and build locally?

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Apr 14, 2026

I almost never look at the modified website: the webpages are essentially markdown (so it's mostly clear how it will look), that how I get by. Do you need to do so for your PR?

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Apr 14, 2026

The other changes looks good to me. Can you update the PR description accordingly? (Otherwise, feel free to mark your PR as ready for review and merge it yourself.)

@adomasbaliuka adomasbaliuka changed the title doc(Tactic/Linter): link to style guide from unicode linter chore(Tactic/Linter): link to style guide from unicode linter Apr 14, 2026
@adomasbaliuka adomasbaliuka changed the title chore(Tactic/Linter): link to style guide from unicode linter chore(Tactic/Linter): unicode linter documentation improvements Apr 14, 2026
@adomasbaliuka
Copy link
Copy Markdown
Collaborator Author

adomasbaliuka commented Apr 14, 2026

Mainly I just thought I should know how to build the docs.

Also, I should check what it looks like at some point as part of "testing" my changes. But if it's hard, I can also wait until it's actually merged and check then. Thanks!

@adomasbaliuka adomasbaliuka marked this pull request as ready for review April 14, 2026 14:11
@adomasbaliuka
Copy link
Copy Markdown
Collaborator Author

bors merge

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 14, 2026

🔒 Permission denied

Existing reviewers: click here to make adomasbaliuka a reviewer

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Apr 14, 2026

Ah, you mean mathlib's docs! Same answer, I guess.

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Apr 14, 2026

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Apr 14, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 14, 2026
As planned in #36773, we add a link to the style guide, which was updated at leanprover-community/leanprover-community.github.io#820.

Further changes:
- some more documentation updates (some obsolete comments were talking about a "blocklist" which no longer exists)
-  change order of checks in `isAllowedCharacter`. The new order is more logical and may slightly improve performance (which probably doesn't matter) since Mathlib has more characters in `otherInMathlib` than `emojis`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 14, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Tactic/Linter): unicode linter documentation improvements [Merged by Bors] - chore(Tactic/Linter): unicode linter documentation improvements Apr 14, 2026
@mathlib-bors mathlib-bors bot closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-linter Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants