Skip to content

feat(RingTheory): lemmas for minimal primes to lessen defeq abuse#38029

Open
Thmoas-Guan wants to merge 3 commits intoleanprover-community:masterfrom
Thmoas-Guan:refactor-minimalPrimes-API
Open

feat(RingTheory): lemmas for minimal primes to lessen defeq abuse#38029
Thmoas-Guan wants to merge 3 commits intoleanprover-community:masterfrom
Thmoas-Guan:refactor-minimalPrimes-API

Conversation

@Thmoas-Guan
Copy link
Copy Markdown
Collaborator

Remove access by .1.1 and .1.2 to mem minimal primes.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary 2ff88851d5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Ideal.le_minimalPrimes
+ minimalPrimes_isPrime

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-ring-theory Ring theory label Apr 14, 2026
@Thmoas-Guan Thmoas-Guan requested a review from erdOne April 14, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants