Skip to content

[Merged by Bors] - chore(FunctionField): move inftyValuation and FqtInfty to RatFunc namespace#38030

Closed
xgenereux wants to merge 6 commits intoleanprover-community:masterfrom
xgenereux:RatFunc.InftyValuation-move
Closed

[Merged by Bors] - chore(FunctionField): move inftyValuation and FqtInfty to RatFunc namespace#38030
xgenereux wants to merge 6 commits intoleanprover-community:masterfrom
xgenereux:RatFunc.InftyValuation-move

Conversation

@xgenereux
Copy link
Copy Markdown
Collaborator

From this discussion.

Move RatFunc results from FunctionField field to RatFunc folder and namespace.

Note : I used Claude Code to produce the deprecations.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

PR summary 044631201f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
3 files Mathlib.NumberTheory.ClassNumber.FunctionField Mathlib.NumberTheory.FunctionField Mathlib.NumberTheory.RatFunc.Ostrowski
1
Mathlib.FieldTheory.RatFunc.Valuation (new file) 2240

Declarations diff

+ FtInfty
+ InftyValuation.map_add_le_max'
+ InftyValuation.map_mul'
+ InftyValuation.map_one'
+ InftyValuation.map_zero'
+ _root_.RatFunc.CompletionAtInfty
+ inftyValuation
+ inftyValuation.C
+ inftyValuation.X
+ inftyValuation.X_inv
+ inftyValuation.X_zpow
+ inftyValuation.polynomial
+ inftyValuationDef
+ inftyValuation_apply
+ inftyValuation_of_nonzero
+ inftyValued
+ inftyValued.def
+ inftyValuedFt
+ inftyValuedFt.def
+ instance : Valued (CompletionAtInfty F) ℤᵐ⁰ := (inftyValued F).valuedCompletion
+ valuedCompletionAtInfty.def
+ valuedFtInfty
+ valuedFtInfty.def
- _root_.FunctionField.FqtInfty
- inftyValuedFqt
- inftyValuedFqt.def
- valuedFqtInfty
- valuedFqtInfty.def

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@xgenereux
Copy link
Copy Markdown
Collaborator Author

As this comes from the FunctionField.lean file, I did not know what to put in the copyright and references for these results. I have just copied them from that file for now. Open to suggestions!

@MichaelStollBayreuth
Copy link
Copy Markdown
Contributor

I did not know what to put in the copyright

I think it is perfectly OK to copy the info from the original file.

@MichaelStollBayreuth
Copy link
Copy Markdown
Contributor

Thanks for doing this! I'll have some comments on the naming.

@MichaelStollBayreuth MichaelStollBayreuth self-assigned this Apr 14, 2026
@MichaelStollBayreuth MichaelStollBayreuth added awaiting-author A reviewer has asked the author a question or requested changes. t-algebra Algebra (groups, rings, fields, etc) labels Apr 14, 2026
@xgenereux xgenereux removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 14, 2026
@MichaelStollBayreuth
Copy link
Copy Markdown
Contributor

Thanks! LGTM.

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by MichaelStollBayreuth.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 14, 2026
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 14, 2026
mathlib-bors bot pushed a commit that referenced this pull request Apr 14, 2026
…c` namespace (#38030)

From [this discussion](#37894 (comment)).

Move `RatFunc` results from `FunctionField` field to `RatFunc` folder and namespace.

Note : I used Claude Code to produce the deprecations.

Co-authored-by: Xavier Genereux <xaviergenereux@hotmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 14, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(FunctionField): move inftyValuation and FqtInfty to RatFunc namespace [Merged by Bors] - chore(FunctionField): move inftyValuation and FqtInfty to RatFunc namespace Apr 14, 2026
@mathlib-bors mathlib-bors bot closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants