Skip to content

perf: unbundle algebra from ENormed*, April 2026 version#38032

Open
grunweg wants to merge 7 commits intoleanprover-community:masterfrom
grunweg:unbundle-enormed-apr2026
Open

perf: unbundle algebra from ENormed*, April 2026 version#38032
grunweg wants to merge 7 commits intoleanprover-community:masterfrom
grunweg:unbundle-enormed-apr2026

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Apr 14, 2026

Up-to-date version of #28803. Don't merge yet!


Open in Gitpod

@grunweg grunweg added WIP Work in progress awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Apr 14, 2026
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Apr 14, 2026

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 14, 2026

Benchmark results for ad7dcd1 against 0446312 are in. (These commits have already been benchmarked in a previous command.) No significant results found. @grunweg

  • build//instructions: -98.7G (-0.06%)

Medium changes (1✅)

  • build/module/Mathlib.MeasureTheory.Group.FundamentalDomain//instructions: -9.9G (-10.30%)

Small changes (13✅)

  • build/module/Mathlib.Algebra.Ring.Fin//instructions: -115.9M (-2.62%)
  • build/module/Mathlib.Analysis.CStarAlgebra.ContinuousFunctionalCalculus.Continuity//instructions: -3.0G (-2.27%)
  • build/module/Mathlib.Analysis.Calculus.Taylor//instructions: -1.3G (-1.50%)
  • build/module/Mathlib.Geometry.Manifold.VectorBundle.CovariantDerivative.Torsion//instructions: -590.4M (-1.87%)
  • build/module/Mathlib.MeasureTheory.Measure.Prokhorov//instructions: -1.2G (-2.54%)
  • build/module/Mathlib.NumberTheory.ModularForms.Bounds//instructions: -1.2G (-2.72%)
  • build/module/Mathlib.NumberTheory.ModularForms.Cusps//instructions: -1.2G (-2.45%)
  • build/module/Mathlib.NumberTheory.ModularForms.EisensteinSeries.Defs//instructions: -3.4G (-11.24%)
  • build/module/Mathlib.NumberTheory.ModularForms.NormTrace//instructions: -1.2G (-3.88%)
  • build/module/Mathlib.NumberTheory.NumberField.Ideal.Basic//instructions: -896.9M (-6.75%)
  • build/module/Mathlib.Probability.Distributions.TwoValued//instructions: -507.9M (-3.84%)
  • build/module/Mathlib.Probability.Process.LocalProperty//instructions: -623.3M (-2.03%)
  • build/module/Mathlib.Topology.EMetricSpace.PairReduction//instructions: -830.6M (-2.17%)

@github-actions github-actions bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 14, 2026
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Apr 14, 2026

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 14, 2026

Benchmark results for ad7dcd1 against 0446312 are in. (These commits have already been benchmarked in a previous command.) No significant results found. @grunweg

  • build//instructions: -98.7G (-0.06%)

Medium changes (1✅)

  • build/module/Mathlib.MeasureTheory.Group.FundamentalDomain//instructions: -9.9G (-10.30%)

Small changes (13✅)

  • build/module/Mathlib.Algebra.Ring.Fin//instructions: -115.9M (-2.62%)
  • build/module/Mathlib.Analysis.CStarAlgebra.ContinuousFunctionalCalculus.Continuity//instructions: -3.0G (-2.27%)
  • build/module/Mathlib.Analysis.Calculus.Taylor//instructions: -1.3G (-1.50%)
  • build/module/Mathlib.Geometry.Manifold.VectorBundle.CovariantDerivative.Torsion//instructions: -590.4M (-1.87%)
  • build/module/Mathlib.MeasureTheory.Measure.Prokhorov//instructions: -1.2G (-2.54%)
  • build/module/Mathlib.NumberTheory.ModularForms.Bounds//instructions: -1.2G (-2.72%)
  • build/module/Mathlib.NumberTheory.ModularForms.Cusps//instructions: -1.2G (-2.45%)
  • build/module/Mathlib.NumberTheory.ModularForms.EisensteinSeries.Defs//instructions: -3.4G (-11.24%)
  • build/module/Mathlib.NumberTheory.ModularForms.NormTrace//instructions: -1.2G (-3.88%)
  • build/module/Mathlib.NumberTheory.NumberField.Ideal.Basic//instructions: -896.9M (-6.75%)
  • build/module/Mathlib.Probability.Distributions.TwoValued//instructions: -507.9M (-3.84%)
  • build/module/Mathlib.Probability.Process.LocalProperty//instructions: -623.3M (-2.03%)
  • build/module/Mathlib.Topology.EMetricSpace.PairReduction//instructions: -830.6M (-2.17%)

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 14, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

PR summary 044631201f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance : ENormedAddMonoid ℝ≥0∞
- NormedCommGroup.toENormedCommMonoid
- instance : ENormedAddCommMonoid ℝ≥0∞

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (2.00, 0.09)
Current number Change Type
23 2 disabled deprecation lints

Current commit ad7dcd1f02
Reference commit 044631201f

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants