Skip to content

feat(Data/Set): add subsingleton_iff_eq_empty_or_singleton#38033

Open
JadAbouHawili wants to merge 5 commits intoleanprover-community:masterfrom
JadAbouHawili:orig-remote
Open

feat(Data/Set): add subsingleton_iff_eq_empty_or_singleton#38033
JadAbouHawili wants to merge 5 commits intoleanprover-community:masterfrom
JadAbouHawili:orig-remote

Conversation

@JadAbouHawili
Copy link
Copy Markdown
Contributor


proof needs to be golfed, got lost in the api so any feedback/review is appreciated

Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Apr 14, 2026
@github-actions
Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

PR summary 044631201f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ subsingleton_iff_eq_empty_or_singleton

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Apr 14, 2026
@grunweg grunweg added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Apr 14, 2026
@themathqueen themathqueen added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 14, 2026
JadAbouHawili and others added 2 commits April 14, 2026 14:39
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
@JadAbouHawili
Copy link
Copy Markdown
Contributor Author

-awaiting-author

@github-actions github-actions bot removed awaiting-author A reviewer has asked the author a question or requested changes. awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Apr 14, 2026
@JadAbouHawili
Copy link
Copy Markdown
Contributor Author

easy

@github-actions github-actions bot added the easy < 20s of review time. See the lifecycle page for guidelines. label Apr 14, 2026
@JadAbouHawili
Copy link
Copy Markdown
Contributor Author

t-set-theory

@github-actions github-actions bot added the t-set-theory Set theory label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-data Data (lists, quotients, numbers, etc) t-set-theory Set theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants