Skip to content

chore(Topology): UniformSpace.Completion renames for morphisms#38039

Draft
themathqueen wants to merge 1 commit intoleanprover-community:masterfrom
themathqueen:UniformSpace.Completion.api
Draft

chore(Topology): UniformSpace.Completion renames for morphisms#38039
themathqueen wants to merge 1 commit intoleanprover-community:masterfrom
themathqueen:UniformSpace.Completion.api

Conversation

@themathqueen
Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen commented Apr 14, 2026

  • UniformSpace.Completion.mapRingHom -> UniformSpace.RingHom.completion
  • [ ]

Just starting this now so that I don't forget again. Will hopefully get to it soon.

See Zulip thread: #mathlib4 > naming convention: UniformSpace.Completion morphisms

Open in Gitpod

@themathqueen themathqueen added the WIP Work in progress label Apr 14, 2026
@github-actions
Copy link
Copy Markdown

PR summary 447620bbe9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.UniformSpace.RingHom.coe_completion
+ _root_.UniformSpace.RingHom.completion
+ _root_.UniformSpace.RingHom.completion_apply
+ _root_.UniformSpace.RingHom.completion_coe
+ _root_.UniformSpace.RingHom.completion_comp
+ _root_.UniformSpace.RingHom.completion_id

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-topology Topological spaces, uniform spaces, metric spaces, filters WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant