feat(Order/ConditionallyCompleteLattice): ConditionallyCompleteSemiLatticeInf#38192
feat(Order/ConditionallyCompleteLattice): ConditionallyCompleteSemiLatticeInf#38192Jun2M wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
Jun2M
commented
Apr 18, 2026
|
This pull request is now in draft mode. No active bors state needed cleanup. While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like |
PR summary 9036ce5439Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
vihdzp
left a comment
There was a problem hiding this comment.
The design looks reasonable to me, but do you have any examples of structures that would fit these instances?
| complete lattices, we prefix `sSup` by a `c` everywhere. The same statements should | ||
| hold in both worlds, sometimes with additional assumptions of nonemptiness or | ||
| boundedness. -/ | ||
| class ConditionallyCompleteSemiLatticeSup (α : Type*) extends SemilatticeSup α, SupSet α where |
There was a problem hiding this comment.
| class ConditionallyCompleteSemiLatticeSup (α : Type*) extends SemilatticeSup α, SupSet α where | |
| class ConditionallyCompleteSemilatticeSup (α : Type*) extends SemilatticeSup α, SupSet α where |
| complete lattices, we prefix `sInf` by a `c` everywhere. The same statements should | ||
| hold in both worlds, sometimes with additional assumptions of nonemptiness or | ||
| boundedness. -/ | ||
| @[to_dual] |
There was a problem hiding this comment.
| @[to_dual] | |
| @[to_dual existing] |
| complete lattices, we prefix `sSup` by a `c` everywhere. The same statements should | ||
| hold in both worlds, sometimes with additional assumptions of nonemptiness or | ||
| boundedness. -/ | ||
| class ConditionallyCompleteSemiLatticeSupBot (α : Type*) extends |
There was a problem hiding this comment.
You could get rid of this by adding a requirement to conditionally complete (semi)lattices that if they have a bottom/top, then the supremum/infimum of the empty set equals to it. I think that'd be a worthwhile refactor which can be done independently of adding these semilattice instances.