Skip to content

chore(Data/Prod/Lex): use to_dual#38196

Open
vihdzp wants to merge 1 commit intoleanprover-community:masterfrom
vihdzp:lex
Open

chore(Data/Prod/Lex): use to_dual#38196
vihdzp wants to merge 1 commit intoleanprover-community:masterfrom
vihdzp:lex

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Apr 18, 2026


Open in Gitpod

@vihdzp vihdzp requested a review from JovanGerb April 18, 2026 06:24
@vihdzp vihdzp added the t-order Order theory label Apr 18, 2026
@github-actions
Copy link
Copy Markdown

PR summary 1708ec1fd9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ toLex_ge_toLex
+ toLex_gt_toLex
- noMinOrder_of_left
- noMinOrder_of_right
- orderTop

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Apr 18, 2026
@vihdzp vihdzp changed the title chore(Mathlib/Data/Prod/Lex): use to_dual chore(Data/Prod/Lex): use to_dual Apr 18, 2026
Copy link
Copy Markdown
Contributor

@JovanGerb JovanGerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It's slightly awkward that we have to add the new toLex_ge_toLex theorem. I could imagine a feature where we could just tag toLex_le_toLex with

@[to_dual none := by rw [eq_comm, toLex_le_toLex]]

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by JovanGerb.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-data Data (lists, quotients, numbers, etc) t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants