refactor: golf only Padics/Hensel, NumberField/Norm#38203
Open
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
Open
refactor: golf only Padics/Hensel, NumberField/Norm#38203yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
Padics/Hensel, NumberField/Norm#38203yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary 0e6b5bebd4Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR selectively ports part of #38144 and only migrates the changes in:
Mathlib/NumberTheory/Padics/Hensel.leanMathlib/NumberTheory/NumberField/Norm.leanConcretely, this PR:
Padics/Henselby extracting the duplicated root-uniqueness argument into a shared private lemmaa_soln_is_uniquesoln_uniqueto first transport the distance bound tosolnviasoln_deriv_norm, then close the proof by applying that shared uniqueness lemma, instead of redoing the full binomial-expansion argument inlineNumberField/Normby movingisUnit_norm_of_isGaloisto sit afterdvd_normand shortening its proof to a direct application ofdvd_normtogether withisUnit_of_dvd_unit