Skip to content

refactor: golf only Padics/Hensel, NumberField/Norm#38203

Open
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
yuanyi-350:golf_67
Open

refactor: golf only Padics/Hensel, NumberField/Norm#38203
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
yuanyi-350:golf_67

Conversation

@yuanyi-350
Copy link
Copy Markdown
Collaborator

@yuanyi-350 yuanyi-350 commented Apr 18, 2026

This PR selectively ports part of #38144 and only migrates the changes in:

  • Mathlib/NumberTheory/Padics/Hensel.lean
  • Mathlib/NumberTheory/NumberField/Norm.lean

Concretely, this PR:

  • refactors Padics/Hensel by extracting the duplicated root-uniqueness argument into a shared private lemma a_soln_is_unique
  • rewrites soln_unique to first transport the distance bound to soln via soln_deriv_norm, then close the proof by applying that shared uniqueness lemma, instead of redoing the full binomial-expansion argument inline
  • refactors NumberField/Norm by moving isUnit_norm_of_isGalois to sit after dvd_norm and shortening its proof to a direct application of dvd_norm together with isUnit_of_dvd_unit

@github-actions
Copy link
Copy Markdown

PR summary 0e6b5bebd4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant