fix: generalize getGithubBaseUrl to support any github-compatible forge#381
Merged
hargoniX merged 3 commits intoleanprover:mainfrom Apr 13, 2026
Merged
Conversation
The original implementation only accepted github.com URLs. This change generalizes it to accept any HTTPS or SSH git remote: - https://host/org/repo[.git] (GitHub, GitHub Enterprise, Codeberg, Gitea) - git@host:org/repo.git (any SSH remote) This fixes srcUri.github failures for: - GitHub Enterprise (e.g., github.jpl.nasa.gov) - Codeberg/Forgejo/Gitea (e.g., codeberg.org) Note: Source links use GitHub's /blob/COMMIT/path convention. For non-GitHub forges (Codeberg uses /src/commit/), use DOCGEN_SRC=file.
hargoniX
approved these changes
Apr 13, 2026
Co-authored-by: Henrik Böving <hargonix@gmail.com>
Collaborator
|
Thanks for your nice PRs as always! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #380
Summary
Generalizes
getGithubBaseUrlto accept any HTTPS or SSH git remote URL, not justgithub.com. This fixessrcUri.githubfailures for GitHub Enterprise and other git forges.Changes
lakefile.lean—getGithubBaseUrl:git@<host>:<org>/<repo>.gitinstead of onlygit@github.com:…. Extractshostby splitting on:.https://<host>/<org>/<repo>[.git]instead of onlyhttps://github.com/…. Validates at least 3 path components (host/org/repo).Before / After
https://github.com/org/reposome "https://github.com/org/repo"some "https://github.com/org/repo"https://ghe.corp.com/org/reponone(error)some "https://ghe.corp.com/org/repo"git@ghe.corp.com:org/repo.gitnone(error)some "https://ghe.corp.com/org/repo"https://codeberg.org/org/repo.gitnone(error)some "https://codeberg.org/org/repo"Caveats
Source links use
/blob/COMMIT/path(GitHub convention). For Codeberg/Forgejo/Gitea (which use/src/commit/COMMIT/path), the generated links won't resolve —DOCGEN_SRC=fileremains the workaround. A follow-up could add aDOCGEN_SRC=urlmode or auto-detect the forge type.Testing
Verified with a project hosted on JPL's GitHub Enterprise