Open
Conversation
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Contributor
Author
|
!radar |
|
Benchmark results for 38d20b0 against 3ea59e1 are in! @datokrat
Large changes (1🟥)
Small changes (2✅, 21🟥) Too many entries to display here. View the full report on radar instead. |
This PR adds comprehensive verification lemmas for the stepSize iterator combinator, including atIdxSlow?_stepSize, atIdxSlow?_intermediate_stepSize, and getElem?_toList_stepSize. It also proves the sorry in IterM.atIdxSlow?_eq_match, adds a missing docstring for Iter.IsPlausibleNthOutputStep, and fixes unused variable warnings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This PR adds a theorem proving that the length of a stepSize iterator relates to the original iterator's length via ceiling division: `(it.stepSize n).length = (it.length + (n - 1)) / (n - 1 + 1)`. Also adds the generalized intermediate version `length_intermediate_stepSize` and supporting helper lemmas connecting `nextAtIdxSlow?` results to length bounds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This PR provides a LawfulDeterministicIterator instance for StepSizeIterator, proving that the stepSize combinator preserves determinism when the base iterator is deterministic. Also removes commented-out code from previous incomplete attempts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…d combinators This PR adds LawfulDeterministicIterator instances for ListIterator, ArrayIterator, Zipper, AssocListIterator, FilterMap (pure), Map (pure), and Flatten combinators, enabling deterministic reasoning about tree map and hash map iterators built from these components. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This PR adds a theorem relating toArray indexing on stepSize iterators to toArray indexing on the underlying iterator, complementing the existing toList and atIdxSlow? versions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…xoIterator This PR adds LawfulDeterministicIterator instances for the tree map range iterators RxcIterator and RxoIterator, complementing the existing Zipper instance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
38d20b0 to
9f7df0e
Compare
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Mar 9, 2026
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Mar 9, 2026
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides lemmas about the
it.stepSize niterator.