feat: revamp infoview options and actions#606
Merged
Conversation
Vtec234
approved these changes
Apr 18, 2025
Member
Vtec234
left a comment
There was a problem hiding this comment.
I have not looked at the implementation at all, but everything seems to work when tested locally.
|
Why were the 'Copy to comment' and 'Copy to clipboard' actions removed without any announcement or discussion in the Lean community Zulip? I used those features often and was dismayed that they just suddenly disappeared. |
mhuisi
added a commit
that referenced
this pull request
Aug 14, 2025
This PR re-adds the copy state/message to clipboard functionality after it was removed in #606. The functionality is available from the context menu (as the other "edit" webview actions are), not from an icon button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR revamps the option and action UX of the InfoView. This work is motivated by several reports from users that they never knew that certain InfoView functionality existed, and intends to make these features more discoverable. Closes #592.
Specifically, the following adjustments are made:
saveConfigButtonandsaveConfigLineBreakclasses.reverseTacticState,showGoalNamesandemphasizeFirstGoalsettings have been made available in the InfoView goal state settings menu.lean4.infoview.showExpectedTypesetting has been deprecated in favor of the newlean4.infoview.expectedTypeVisibilitysetting, which allows hiding the expected type section entirely, as this section was reported to be confusing for students in a teaching environment.Adjusted InfoView UI (Click to open)
New settings menu (Click to open)
New InfoView context menu (Click to open)