subtractWorkingTime of "moment.invalid(/* undefined */)" loops infinitely

[diequeiroz]

Using 0.7.1

This condition:

var moment = require('moment-business-time');
moment(undefined, 'DD/MM/YYYY 00:00').subtractWorkingTime(1, 'day')

Makes this function loops infinitely.

[lennym]

Thanks for opening an issue @diequeiroz - I'll try to get this fixed asap, but it might be a few days before I get a chance to look at it. I'd be happy to merge a PR in the interim.

[mark-monteiro]

For anyone else who stumbles upon this issue, you can patch this fairly easily from your own code. This Typescript code example patches the functions to return the unmodified provided moment object if it is invalid. You could also throw an error if you want.

import moment, { Duration, Moment, unitOfTime } from "moment";
import "moment-business-time";

const addWorkigTimeOriginal = moment.fn.addWorkingTime;
const subtractWorkingTimeOriginal = moment.fn.subtractWorkingTime;

moment.fn.addWorkingTime = function (this: Moment, ...args: Array<number | unitOfTime.Base>): Moment {
  if (!this.isValid()) return this;
  return addWorkigTimeOriginal.call(this, ...args);
};

moment.fn.subtractWorkingTime = function (this: Moment, ...args: Array<number | unitOfTime.Base>): Moment {
  if (!this.isValid()) return this;
  return subtractWorkingTimeOriginal.call(this, ...args);
};