Conversation
…sure our choice prevails Fixes #716
|
Just started reviewing :) |
|
Umm, let me see if I understood correctly the issue: And why do we do this, user's preferences always have precedence? |
|
Hey Iliyan! Yeah, on top of user preferences, I think we always want our swap to prevail. We added that so users would only need to add Also, in some cases like server-side generated config, they won't even be able to decide which one should they use. That's why we always need to do the replace at the end. And yeah, what you say is exactly what happens... which we meant to fix originally by replacing the default plugins ourselves. |
|
Thank you, pull request merged! See changes here. |
|
Okay... then we can merge this one for now. Thanks! |
Hey @ipeychev, I've rebased and fixed the conflicts. Turns out the test file was conflicting with some previously added ones... I think it's the first time we run into problems by writing too many tests 😂