Fixes #876 | Fix toolbar position#887
Closed
julien wants to merge 1 commit intoliferay:developfrom
julien:pr-877
Closed
Fixes #876 | Fix toolbar position#887julien wants to merge 1 commit intoliferay:developfrom julien:pr-877
julien wants to merge 1 commit intoliferay:developfrom
julien:pr-877
Conversation
Contributor
|
Hey @julien, this looks much better!! 👏 I've found a bit of an edge case that I'd like to try to fix before we merge this in. Looks like when we re-render the toolbar in some cases it overflows the page. See the screencast when applying a text change or clicking on the link button on the right margin.
Could you try to figure out what's wrong there? Thanks! |
Contributor
Author
|
Hey @jbalsas, Yes it looks like I totally missed that one. Thanks |
Contributor
Author
|
Pull request submitted to #888 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.