Skip to content

Add extra buttons from liferay-portal#954

Merged
julien merged 11 commits intoliferay:2.x-developfrom
julien:feature/extra_buttons
Jan 18, 2019
Merged

Add extra buttons from liferay-portal#954
julien merged 11 commits intoliferay:2.x-developfrom
julien:feature/extra_buttons

Conversation

@julien
Copy link
Copy Markdown
Contributor

@julien julien commented Jan 16, 2019

Hey @jbalsas and @wincent,

This add the extra buttons that we had in liferay-portal.

There are probably still a few things to clean up and maybe discuss for this to be totally finished but I thought I'd send you the PR so we can start the conversation.

On the top of my head these are the main things that need to be finished or at least that you should be aware of.

  • The button-camera-image.jsx component has been fixed, I discovered it was no longer working in Chrome or Safari while working on this task.
  • The button-link-browse.jsx component was using AUI (I removed that), we talked about either emitting an event or allowing passing a callback, it might be a good time to talk about it together and decide what which solution seems "right".
  • We still need to figure out how to make the embedurl plugin work outside the portal, but @jbalsas and I already agreed that we would have a look at it.
  • New styles have been added for the ae-svg-icon css class with @marcoscv-work but please let us know what you think
  • I had to update a few tests because they were relying on css classes that are not used anymore, if there's a cleaner solution, I'm all for it.
  • EDIT: One extra thing: there's still a mix a es5/es6 that we could probably have a look at but I also think we might want another PR for that.

@wincent if you see anything "bad" or crazy don't hesitate your feedback is more than welcome.

Thanks!

Copy link
Copy Markdown
Contributor

@wincent wincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a partial look at this so far. Will continue a bit later.

Copy link
Copy Markdown
Contributor

@wincent wincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments after reading through the whole thing. Pretty great that you were able to make such a large change without anything getting busted. :-)

var instance = this;

var focusAltEl = function () {
ReactDOM.findDOMNode(instance.refs.refAltInput).focus();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of findDOMNode is deprecated (or will be soon) — the suggestion is to use refs instead.

)
} else {
active = false;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if all this would read better with every()? Something like:

return styleConfig.attributes.class.split(' ').every(
  className => elementPath.lastElement.hasClass(className)
);

@julien julien merged commit db9d6b3 into liferay:2.x-develop Jan 18, 2019
@julien julien deleted the feature/extra_buttons branch February 14, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants