Conversation
Applies the suggested fix that is sitting in an unmerged PR on the upstream repo: jquery-form/form#586
In our previous fork of this module, we have an `if (false)` condition
to prevent the module from calling `define`:
https://github.com/liferay/liferay-portal/blob/19d993d6e3c0dd6865924bf23f75992f52fc355e/modules/apps/frontend-js/frontend-js-jquery-web/src/main/resources/META-INF/resources/jquery/form.js#L33
That's pretty ugly, and just stripping out the conditional is a still a
pretty minimal edit, so let's go with that instead. Note that if you
look at the DXP version, we wrap the entire function in a wrapper that
just passes in `window.$` as `jQuery`, but that changes the indentation
level of the entire file, so to make a minimal edit here we don't do
that.
After this change, we're basically identical to what is in DXP (compared
that by source-formatting the file, overwriting it with the DXP copy,
and inspecting the changes with `git diff -w`).
Contributor
Author
|
Going to merge and try a test release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the suggested fix that is sitting in an unmerged PR on the upstream repo and which we previously tried shipping via direct patch.
Needed for: #394