ProblemReporting: support more non-wildcard digits#873
Open
nafg wants to merge 2 commits intolightbend-labs:mainfrom
Open
ProblemReporting: support more non-wildcard digits#873nafg wants to merge 2 commits intolightbend-labs:mainfrom
nafg wants to merge 2 commits intolightbend-labs:mainfrom
Conversation
Contributor
Author
|
Meanwhile worked around it by replacing the |
Closed
Currently this doesn't work correctly for version strings like from sbt-dynver, because it looks at all the digits after the last period. However the digits of a version string like `3.6.1+42-c80fbe6a+20250708-2356-SNAPSHOT` create a number far greater than `Short.MaxValue`. It's even larger than `Int.MaxValue.` So the easiest fix seems to be to just go with `Long.MaxValue`.
Collaborator
|
@nafg I added a few more changes to make the tests pass. LGTY? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently versioned exclusion files don't work correctly for version strings like those from sbt-dynver, because it looks at all the digits after the last period. However the digits of a version string like
3.6.1+42-c80fbe6a+20250708-2356-SNAPSHOTcreate a number far greater thanShort.MaxValue. It's even larger thanInt.MaxValue.So the easiest fix seems to be to just go withLong.MaxValue.