PathParser.fastPathBuild array allocation seems to do nothing

[hkupty]

Hi, I was investigating some performance bottlenecks of an application and interestingly this array allocation appears to be on the on the hotpath. On this 5 minute scan, PathParser.fastPathBuild was responsible for ~6.15% of the 1.23GB object array allocation of the system.

When checking, it seems that the array is allocated but never used. seems like its usage was dropped as of this commit, but it was left there. Is that the case?

[havocp]

Looks true to me! Wouldn't be the first time a thing called "fast" in some code was... not fast. 🙃

[ekrich]

A Token is being added to the array but then the Array doesn't seem to be used afterwords.

[viktorklang]

Wow—nice catch!

[hkupty]

Nice.. I can open a PR to fix - essentially removing those two lines above. Not sure if that's the intended behavior of this function though.

[ekrich]

Nice catch. I removed it from sconfig as well.