Skip to content

[ci] fix flaky test#3056

Merged
jameslamb merged 1 commit intomasterfrom
ci_fix
May 7, 2020
Merged

[ci] fix flaky test#3056
jameslamb merged 1 commit intomasterfrom
ci_fix

Conversation

@StrikerRUS
Copy link
Copy Markdown
Collaborator

I noticed that Linux MPI builds at Azure Pipelines have started to fail (refer for example to #3055). Seems that dropping outdated Python 2.7 version from that build fixes the issue.

On Linux we have tests with Python 2.7 here, so this version is still covered by our CIs.
https://github.com/microsoft/LightGBM/blob/18c706dc840c72341a2a85e05dfb5fad6366902a/.travis.yml#L18

Refer to #1964 (comment).

Copy link
Copy Markdown
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I'm ok with this! I agree with your comment from a previous issue (can't find that link) that we should hang onto Python 2.7 for as long as we can if it doesn't take too much maintenance work from us.

@jameslamb jameslamb merged commit 507ce1b into master May 7, 2020
@jameslamb jameslamb mentioned this pull request May 7, 2020
@StrikerRUS
Copy link
Copy Markdown
Collaborator Author

Thanks! Yeah, our Python wrapper doesn't require any special features from latest versions and thanks to Python internal compatibility our old code works fine with the latest version.

Proportion breakdown says that we can safely drop Python 2 support. But in absolute values it is still several thousands of downloads per day. And those thousands are our users. I think we can try to support it for some months or before next minor release as it doesn't cost us anything.

https://pypistats.org/packages/lightgbm

@StrikerRUS StrikerRUS deleted the ci_fix branch May 7, 2020 22:20
@StrikerRUS StrikerRUS mentioned this pull request May 12, 2020
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this pull request Jun 10, 2020
ChipKerchner pushed a commit to ChipKerchner/LightGBM that referenced this pull request Jun 11, 2020
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants