Skip to content

TW-2973: update chat room preset to private and remove power level overrides#2974

Open
nqhhdev wants to merge 1 commit intomainfrom
TW-2973-update-create-support-chat-flow
Open

TW-2973: update chat room preset to private and remove power level overrides#2974
nqhhdev wants to merge 1 commit intomainfrom
TW-2973-update-create-support-chat-flow

Conversation

@nqhhdev
Copy link
Copy Markdown
Member

@nqhhdev nqhhdev commented Mar 30, 2026

Ticket

Related issue

Resolved

Attach screenshots or videos demonstrating the changes

  • Web:
  • Android:
  • IOS:
Screen.Recording.2026-03-30.at.17.07.08.mov

Summary by CodeRabbit

  • Bug Fixes

    • Updated support chat creation to use standard private chat settings instead of a specialized configuration, with permission levels now managed through default preset behavior rather than explicit customization.
  • Tests

    • Updated test suite to align with changes to support chat configuration and permission-level handling.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 79dbf0ac-0da1-4913-bc33-7f8414b96880

📥 Commits

Reviewing files that changed from the base of the PR and between 196df47 and 1360ecf.

📒 Files selected for processing (2)
  • lib/domain/usecase/room/create_support_chat_interactor.dart
  • test/domain/usecase/room/create_support_chat_interactor_test.dart

Walkthrough

This change modifies the support chat creation flow in the interactor by switching from CreateRoomPreset.trustedPrivateChat to CreateRoomPreset.privateChat and removing the explicit powerLevelContentOverride configuration that was previously customizing power levels for events, invite, and kick operations. The implementation now relies on default preset power-level behavior instead. All subsequent operations including room lookup, invitation, per-user power settings, favorites, and account-data persistence remain unchanged. Corresponding test updates reflect the preset change and removal of power-level mock expectations.

Possibly related PRs

  • #2762: Modifies the same createGroupChat invocation in the support chat interactor by adding an enableEncryption flag alongside other room creation parameters.

Suggested reviewers

  • dab246
  • hoangdat
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete. It only includes the related issue ticket and a video attachment, while missing critical sections like root cause, solution, impact description, test recommendations, and pre-merge requirements. Add missing sections: root cause (why the change was needed), solution (detailed explanation of changes made), impact description, test recommendations, and pre-merge checklist. Ensure all template sections are properly filled.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main changes: updating the chat room preset from trustedPrivateChat to privateChat and removing power level overrides.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch TW-2973-update-create-support-chat-flow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

This PR has been deployed to https://linagora.github.io/twake-on-matrix/2974

@pm-McFly
Copy link
Copy Markdown
Collaborator

@nqhhdev what is the m.room.power_levels call following the room creation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants