Merged
Conversation
Fixed typo for StyledPILImage kwarg: embeded -> embedded
Contributor
Author
|
If needed, I can go through the rest of the code to see if there are references to this kwarg elsewhere to ensure nothing breaks. |
Contributor
|
@benjnicholls Maybe we should accept both arguments for now to keep it backward compatible and raise a deprecation warning when the argument with the typo is used. |
Member
|
Thank you! I added deprecation warnings in ca68b09 for all changes. The typo variants will be removed in v9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed typo for StyledPILImage kwarg: embeded -> embedded