Do not set element id for path generated by SvgPathImage#385
Closed
m000 wants to merge 1 commit intolincolnloop:mainfrom
Closed
Do not set element id for path generated by SvgPathImage#385m000 wants to merge 1 commit intolincolnloop:mainfrom
m000 wants to merge 1 commit intolincolnloop:mainfrom
Conversation
The element id used is hardcoded, which may cause issues when inlining many qr codes in a single document.
bartTC
added a commit
that referenced
this pull request
Jul 23, 2025
Squashed commit of the following:
commit 6001967c18fd334279f2712cffe94ba4018ca227
Author: Martin Mahner <martin@mahner.org>
Date: Wed Jul 23 13:31:36 2025 +0200
Updated changelog
commit 7d5d3b208c8be1e5190c812dd25712cab21dedf7
Merge: 4d3636c 4395902
Author: Martin Mahner <martin@mahner.org>
Date: Wed Jul 23 13:29:00 2025 +0200
Merge branch 'main' into remove-svg-id
commit 4d3636c
Author: Manolis Stamatogiannakis <mstamat@gmail.com>
Date: Mon Oct 28 22:55:31 2024 +0100
Do not set element id for path generated by SvgPathImage
The element id used is hardcoded, which may cause issues when inlining
many qr codes in a single document.
Member
|
This has been merged in ac2dda2. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The element id used is hardcoded, which may cause issues when inlining many qr codes in a single document.
Proposed fix for #384.