Conversation
Contributor
ikhoon
reviewed
Feb 24, 2025
core/src/main/java/com/linecorp/armeria/internal/server/annotation/AnnotatedValueResolver.java
Outdated
Show resolved
Hide resolved
@Param Map<String, List<?>>
minwoox
approved these changes
Apr 9, 2025
Contributor
minwoox
left a comment
There was a problem hiding this comment.
Left small suggestions. Thanks!
core/src/main/java/com/linecorp/armeria/internal/server/annotation/AnnotatedValueResolver.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/internal/server/annotation/AnnotatedValueResolver.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the suggestions, @minwoox! |
236cb7f to
d7daa0d
Compare
jrhee17
approved these changes
Apr 16, 2025
core/src/main/java/com/linecorp/armeria/internal/server/annotation/AnnotatedValueResolver.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/internal/server/annotation/AnnotatedValueResolver.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/internal/server/annotation/AnnotatedValueResolver.java
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the suggestions, @jrhee17 ! |
95ad3d0 to
0dff99c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6118 +/- ##
============================================
+ Coverage 74.46% 74.64% +0.17%
- Complexity 22234 22480 +246
============================================
Files 1963 1972 +9
Lines 82437 83018 +581
Branches 10764 10805 +41
============================================
+ Hits 61385 61967 +582
+ Misses 15918 15901 -17
- Partials 5134 5150 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Daeho Kwon <trewq231@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
This PR is a follow-up to #6072, which added support for mapping all query parameters into a Map<String, String>. However, it does not handle cases where multiple values exist for the same query parameter key.
For example:
The current implementation only retains the last value
a=2, losinga=1.To better support multi-value query parameters, we introduce support for Map<String, List<?>>.
Modifications:
Result: