Skip to content

fix: rely on gh-upload-log default log routing#1909

Merged
konard merged 7 commits into
mainfrom
issue-1902-0b473b50cb74
Jun 12, 2026
Merged

fix: rely on gh-upload-log default log routing#1909
konard merged 7 commits into
mainfrom
issue-1902-0b473b50cb74

Conversation

@konard

@konard konard commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #1902 by applying the upstream gh-upload-log fallback fix and relying on its default auto mode/shared repository behavior.

Root Cause

The captured log files were below the gist limit, so gh-upload-log 0.8.0 auto mode tried gist upload first. GitHub returned a secondary content-creation rate limit, and the fallback entered repository mode.

In 0.8.0, repository fallback still had useSharedRepository: true, but shared repository routing was incorrectly gated by file size. Sub-25 MB gist failures therefore created one-off log-tmp-* repositories. Upstream PR link-foundation/gh-upload-log#32 fixed that routing, and 0.8.1 published the fix.

Testing

Local checks:

  • npm exec --package=gh-upload-log@0.8.1 -- gh-upload-log /tmp/gh-upload-log-1902-smoke.log --public --dry --verbose
  • node tests/test-issue-1902-log-upload-routing.mjs
  • node tests/test-log-upload.mjs
  • node tests/test-log-upload-output-1678.mjs
  • node tests/test-log-upload-output-1682.mjs
  • npm run format:check
  • npm run lint
  • node scripts/validate-changeset.mjs
  • bash scripts/check-file-line-limits.sh
  • npm test (all 247 selected test files passed)

CI:

Evidence

Adding .gitkeep for PR creation (default mode).
This file will be removed when the task is complete.

Issue: #1902
@konard konard self-assigned this Jun 11, 2026
@konard konard changed the title [WIP] Something is not yet switched to private and public logs via gh upload tool fix: force explicit gh-upload-log modes Jun 11, 2026
@konard konard marked this pull request as ready for review June 11, 2026 16:23
@konard

konard commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Working session summary

Implemented and pushed the fix to PR 1909: #1909

What changed:

  • Forced gh-upload-log into explicit modes:
    • --only-gist for logs within the GitHub file limit.
    • --only-repository --shared-repository for oversized logs.
  • Based routing on the sanitized temp file that is actually uploaded.
  • Added regression coverage in tests/test-issue-1902-log-upload-routing.mjs.
  • Added the issue evidence and root-cause writeup under docs/case-studies/issue-1902/.

Verification:

  • npm run format:check
  • npm run lint
  • node scripts/validate-changeset.mjs
  • bash scripts/check-file-line-limits.sh
  • npm test after merging latest origin/main: all 245 selected test files passed
  • GitHub Actions latest run for head d73172d1 completed successfully

PR is marked ready for review.


This summary was automatically extracted from the AI working session output.

@konard

konard commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Solution Draft Log

This log file contains the complete execution trace of the AI solution draft process.

💰 Cost estimation:

  • Model: GPT-5.5
  • Provider: OpenAI
  • Public pricing estimate: $26.522229

📊 Context and tokens usage:

  • 673.2K / 1.1M (64%) input tokens, 55.0K / 128K (43%) output tokens

Total: (673.2K + 17.3M cached) input tokens, 55.0K output tokens, $26.522229 cost

🤖 Models used:

  • Tool: OpenAI Codex
  • Requested: gpt-5.5
  • Model: GPT-5.5 (gpt-5.5)

📎 Log file uploaded as Repository (72157KB)


Now working session is ended, feel free to review and add any feedback on the solution draft.

@konard

konard commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

✅ Ready to merge

This pull request is now ready to be merged:

  • All CI checks have passed
  • No merge conflicts
  • No pending changes

Monitored by hive-mind with --auto-restart-until-mergeable flag

@konard

konard commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

I think analysis is wrong. We should support auto mode. And if gist fails, we should fallack to single repository mode, looks like that issue inside gh-upload-log, so the issue must be reported there with suggested workarounds and fix.

So repository per log file should never be used, unless explicitly asked by options in gh-upload-log.

@konard konard marked this pull request as draft June 11, 2026 22:26
@konard

konard commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

🤖 AI Work Session Started

Starting automated work session at 2026-06-11T22:26:33.692Z

The PR has been converted to draft mode while work is in progress.

This comment marks the beginning of an AI work session. Please wait for the session to finish, and provide your feedback.

@konard konard changed the title fix: force explicit gh-upload-log modes fix: keep gh-upload-log auto fallback shared Jun 11, 2026
@konard konard marked this pull request as ready for review June 11, 2026 22:55
@konard

konard commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Working session summary

Implemented and finalized issue #1902.

PR: #1909
Upstream issue filed: link-foundation/gh-upload-log#31

What changed:

  • Kept gh-upload-log in auto mode by default.
  • Added explicit shared fallback args: --auto --shared-repository.
  • Preserved dedicated repository mode only for explicit useSharedRepository: false / --no-shared-repository.
  • Updated the issue Something is not yet switched to private and public logs via gh upload tool #1902 case study and evidence.
  • Merged latest origin/main into the PR branch and pushed commit 885e226d.

Verification:

  • Targeted issue test passed.
  • npm run format:check, npm run lint, changeset validation, and line-limit check passed.
  • Final PR CI passed on 885e226d, including test-suites default suite and GitHub integration suite.
  • PR is marked ready, merge state is CLEAN, and the local worktree is clean.

Note: after merging latest main, local full-suite reruns hit two unrelated intermittent failures; both failed test files passed in isolation, and the final GitHub CI passed for the exact pushed SHA.


This summary was automatically extracted from the AI working session output.

@konard

konard commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Solution Draft Log

This log file contains the complete execution trace of the AI solution draft process.

💰 Cost estimation:

  • Model: GPT-5.5
  • Provider: OpenAI
  • Public pricing estimate: $22.533037

📊 Context and tokens usage:

  • 350.8K / 1.1M (33%) input tokens, 45.0K / 128K (35%) output tokens

Total: (350.8K + 17.0M cached) input tokens, 45.0K output tokens, $22.533037 cost

🤖 Models used:

  • Tool: OpenAI Codex
  • Requested: gpt-5.5
  • Model: GPT-5.5 (gpt-5.5)

📎 Log file uploaded as Repository (48274KB)


Now working session is ended, feel free to review and add any feedback on the solution draft.

@konard

konard commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

✅ Ready to merge

This pull request is now ready to be merged:

  • All CI checks have passed
  • No merge conflicts
  • No pending changes

Monitored by hive-mind with --auto-restart-until-mergeable flag

@konard

konard commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Apply latest version of https://github.com/link-foundation/gh-upload-log to our repository, check that it works as expected, and make sure we use only default auto mode without explicit options (we should only use minimum that is nessesary).

And double check all other changes for correctness and consistency.

@konard konard marked this pull request as draft June 12, 2026 08:15
@konard

konard commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

🤖 AI Work Session Started

Starting automated work session at 2026-06-12T08:15:06.972Z

The PR has been converted to draft mode while work is in progress.

This comment marks the beginning of an AI work session. Please wait for the session to finish, and provide your feedback.

@konard konard changed the title fix: keep gh-upload-log auto fallback shared fix: rely on gh-upload-log default log routing Jun 12, 2026
@konard konard marked this pull request as ready for review June 12, 2026 08:58
@konard

konard commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Working session summary

Continued and finalized PR #1909: #1909

What changed:

  • Applied latest gh-upload-log usage via gh-upload-log@latest.
  • Removed explicit strategy flags from the runtime upload path, relying on default auto mode/shared fallback.
  • Updated the regression test, Docker install points, changeset, case-study evidence, and PR description.
  • Marked the PR ready for review.

Verification:


This summary was automatically extracted from the AI working session output.

@konard

konard commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Solution Draft Log

This log file contains the complete execution trace of the AI solution draft process.

💰 Cost estimation:

  • Model: GPT-5.5
  • Provider: OpenAI
  • Public pricing estimate: $16.432673

📊 Context and tokens usage:

  • 565.2K / 1.1M (54%) input tokens, 48.8K / 128K (38%) output tokens

Total: (565.2K + 8.6M cached) input tokens, 48.8K output tokens, $16.432673 cost

🤖 Models used:

  • Tool: OpenAI Codex
  • Requested: gpt-5.5
  • Model: GPT-5.5 (gpt-5.5)

📎 Log file uploaded as Repository (67405KB)


Now working session is ended, feel free to review and add any feedback on the solution draft.

@konard

konard commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

✅ Ready to merge

This pull request is now ready to be merged:

  • All CI checks have passed
  • No merge conflicts
  • No pending changes

Monitored by hive-mind with --auto-restart-until-mergeable flag

@konard konard merged commit 8028e57 into main Jun 12, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Something is not yet switched to private and public logs via gh upload tool

1 participant