fix(injector): use annotated values for debug container#13778
Merged
Conversation
Issue linkerd#13636 was opened stating that custom debug container annotations had no effect. Quick investigation confirmed the issue and further debugging revealed a bug in code where the final values for helm chart were not using values processed by GetOverriddenValues function and that's why annotations had no effect for debug containers. This had been fixed now. Added to unit test to test added code. Manual testing also done. The issue seems to be resolved. Fixes linkerd#13636 Signed-off-by: Vishal Tewatia <tewatiavishal3@gmail.com>
Contributor
Author
|
for some reason i can't open the issue since yesterday, its still at the top here, is it just me or others aren't able to view the issue as well? |
Member
|
I can't see the issue either, that's weird! Anyways, the problem is clear. Thanks for the submission; I'll give this a look in the next couple of days 👍 |
alpeb
changed the title
alpeb
added a commit
that referenced
this pull request
Mar 18, 2025
Followup to #13778, where a new test case was introduced for testing the debug container annotation, but didn't account for the new LINKERD2_PROXY_CORES_MIN environment variable.
alpeb
added a commit
that referenced
this pull request
Mar 18, 2025
Followup to #13778, where a new test case was introduced for testing the debug container annotation, but didn't account for the new LINKERD2_PROXY_CORES_MIN environment variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #13636 was opened stating that custom debug container annotations had no effect.
Quick investigation confirmed the issue and further debugging revealed a bug in code where the final values for helm chart were not using values processed by GetOverriddenValues function and that's why annotations had no effect for debug containers. This had been fixed now.
Added to unit test to test added code. Manual testing also done. The issue seems to be resolved.
Fixes #13636