Fix #2255: serialize dictionary keys invariantly#2753
Open
JKamsker wants to merge 2 commits into
Open
Conversation
…rg#2255) SerializeDictionary writes non-string keys with key.ToString() (current culture) while DeserializeDictionary parses them with ConvertFromInvariantString. Under a comma-decimal culture (de-DE) a Dictionary<double,double> key 9.9 is stored as "9,9" and cannot be read back, silently losing/corrupting data. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
SerializeDictionary used key.ToString(), which is culture-dependent, while
DeserializeDictionary parses keys with ConvertFromInvariantString. Under a
comma-decimal culture (e.g. de-DE) a Dictionary<double,double> key 9.9 was
stored as "9,9" and silently corrupted on read.
Serialize keys via TypeConverter.ConvertToInvariantString (DateTime keeps the
round-trip "o" format, now explicitly invariant), matching deserialization.
Under invariant/en-US cultures the stored output is unchanged ("9.9"), so this
is not a format change for existing readable databases; data previously written
under a comma-decimal culture was already unreadable and cannot be migrated.
Fixes litedb-org#2255.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2255.
Summary
CurrentCulture.TDD / verification
net8.0test project.Compatibility note
No LiteDB file format change. The fix stabilizes the string representation of dictionary keys going forward.