Fix #996: preserve LiteException messages without format args#2756
Open
JKamsker wants to merge 2 commits into
Open
Fix #996: preserve LiteException messages without format args#2756JKamsker wants to merge 2 commits into
JKamsker wants to merge 2 commits into
Conversation
Add Issue996 coverage for LiteException params constructors receiving no formatting arguments while the message contains brace placeholders. The tests capture the reported String.FormatException before changing production code and also verify normal argument formatting remains intact. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Avoid calling string.Format when LiteException formatting constructors receive a null or empty params array. This keeps literal brace placeholders in diagnostic messages from masking the original error with FormatException while preserving existing formatting when arguments are supplied. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #996.
Summary
string.FormatwhenLiteExceptionformatting constructors receive no arguments.{0}.TDD / verification
net8.0test project.Compatibility note
No on-disk format change. This is an exception-message/runtime behavior fix.