Fix #2190: avoid duplicate id element enumeration#2758
Open
JKamsker wants to merge 2 commits into
Open
Conversation
Add Issue2190 coverage for a typed entity with an _Id property and non-nullable Played field. The tests capture the duplicate _id element enumeration that undersizes the BSON buffer and causes the reported field-name truncation or debug-time insert failure. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Make BsonDocument.GetElements exclude _id using the same case-insensitive comparison as the backing dictionary. This prevents _Id properties from being emitted twice, which undersized BSON buffers and could truncate following field names during insert. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2190.
Summary
BsonDocument.GetElements()exclude_idusing the same case-insensitive comparison as the backing dictionary._Idproperties from being emitted twice during serialization.PlayedbecomingPla.TDD / verification
BsonDocument.GetElements()duplicate element bug._IdandPlayedproperties.net8.0test project.Compatibility note
No valid on-disk format is changed. The affected documents either failed to serialize in debug builds or could be written corrupted in release builds; this prevents new corruption.