Skip to content

Initial commit for dev branch: Setup basic app structure and Minikube config#17

Merged
lkevenson merged 12 commits intomainfrom
dev
Apr 11, 2025
Merged

Initial commit for dev branch: Setup basic app structure and Minikube config#17
lkevenson merged 12 commits intomainfrom
dev

Conversation

@lkevenson
Copy link
Copy Markdown
Owner

@lkevenson lkevenson commented Apr 4, 2025

… config

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: Spring Petclinic Commit Message Guidelines
  • All tests are passing (unit, integration, and end-to-end tests where applicable).
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).
  • Code coverage is sufficient, or additional tests have been added to cover new changes.
  • No linting or formatting issues.
  • Code adheres to the project's style guide and best practices.
  • Any necessary dependencies have been updated.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@lkevenson lkevenson linked an issue Apr 4, 2025 that may be closed by this pull request
ubuntu version error #18
Closed
lkevenson added 11 commits April 4, 2025 16:25
@lkevenson
fix(ci): update GitHub Actions to v4 and Ubuntu 24.04 compatibility
979f025 
- Migrate from deprecated actions/upload-artifact@v3 to @v4
- Update actions/setup-java and actions/cache to v4
- Add explicit Minikube and MySQL client installation
- Fix output setting syntax for GITHUB_OUTPUT
- Specify ubuntu-24.04 runner explicitly
@lkevenson
fix: Resolve test failures due to missing database tables
565c8a2
@lkevenson
fix: Resolve test failures due to missing database tables
6f1d7fd
@lkevenson
fix: change dev.yml file
86f4a21
@lkevenson
fix(ci): correct Minikube setup in GitHub Actions
df91c33 
- Fix 'source' command syntax for minikube docker-env
- Add explicit Docker installation before Minikube
- Include proper environment setup for Minikube context
- Add error handling for Minikube initialization
- Update Minikube version to 1.35.0

Error resolved:
* Fixed 'source: usage: source filename [arguments]' error
* Ensures proper Docker environment configuration
* Prevents exit code 2 during Minikube setup
@lkevenson
fix(ci): resolve containerd dependency conflict in Ubuntu 24.04
5293aa5 
- Remove existing containerd before installing docker.io
- Add explicit containerd.io installation
- Clean up package cache before installation
- Add error handling for package installation
@lkevenson
fix(ci): simplify dependencies and remove unnecessary packages
751fec3 
- Remove problematic docker-buildx-plugin installation
- Simplify to only essential packages (docker.io, conntrack, curl)
- Clean up redundant dependency cleanup steps
- Maintain core Minikube deployment functionality
- Add || true for non-critical usermod command

The buildx plugin isn't required for basic Minikube deployments.
This change resolves the package installation errors while keeping
all necessary functionality for the Spring PetClinic deployment.
@lkevenson
ci: ensure required system dependencies for Minikube
1f47883 
- Keep docker.io, conntrack, and curl installation (critical for Minikube)
- Add containerd conflict resolution
- Add Docker version check for validation
- Skip usermod errors safely in CI

These packages are required because:
- docker.io: Container runtime for Minikube
- conntrack: Kubernetes networking requirement
- curl: Needed to fetch Minikube binary
@lkevenson
ci: ensure required system dependencies for Minikube
b2b33f7 
- Keep docker.io, conntrack, and curl installation (critical for Minikube)
- Add containerd conflict resolution
- Add Docker version check for validation
- Skip usermod errors safely in CI

These packages are required because:
- docker.io: Container runtime for Minikube
- conntrack: Kubernetes networking requirement
- curl: Needed to fetch Minikube binary
@lkevenson
fix(ci): robust system dependencies installation with conflict resolu…
afc67ce 
…tion

- Add comprehensive containerd/docker conflict handling
- Implement fallback installation paths
- Include verification steps for all tools
- Suppress non-critical errors in CI environment
- Ensure Docker is properly configured and running

The improved installation process now:
1. Handles package conflicts gracefully
2. Works across different Ubuntu/Docker versions
3. Provides verification of successful setup
4. Prevents CI failures from benign issues
@lkevenson
fix(ci): robust system dependencies installation with conflict resolu…
f87eb97 
…tion

- Add comprehensive containerd/docker conflict handling
- Implement fallback installation paths
- Include verification steps for all tools
- Suppress non-critical errors in CI environment
- Ensure Docker is properly configured and running

The improved installation process now:
1. Handles package conflicts gracefully
2. Works across different Ubuntu/Docker versions
3. Provides verification of successful setup
4. Prevents CI failures from benign issues
@lkevenson lkevenson merged commit 9f3e842 into main Apr 11, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ubuntu version error

1 participant

@lkevenson
⚡